Title: [275436] trunk/Source/WebCore
- Revision
- 275436
- Author
- [email protected]
- Date
- 2021-04-02 14:04:53 -0700 (Fri, 02 Apr 2021)
Log Message
UBSan: AlternativeTextController::dismiss()/dismissSoon(): runtime error: load of value nnn, which is not a valid value for type 'bool'
<https://webkit.org/b/223903>
Reviewed by Wenson Hsieh.
Covered by 449 layout tests using WebKit compiled with UBSan.
* editing/AlternativeTextController.h:
- Initialize m_isActive and m_isDismissedByEditing.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (275435 => 275436)
--- trunk/Source/WebCore/ChangeLog 2021-04-02 20:23:26 UTC (rev 275435)
+++ trunk/Source/WebCore/ChangeLog 2021-04-02 21:04:53 UTC (rev 275436)
@@ -1,3 +1,15 @@
+2021-04-02 David Kilzer <[email protected]>
+
+ UBSan: AlternativeTextController::dismiss()/dismissSoon(): runtime error: load of value nnn, which is not a valid value for type 'bool'
+ <https://webkit.org/b/223903>
+
+ Reviewed by Wenson Hsieh.
+
+ Covered by 449 layout tests using WebKit compiled with UBSan.
+
+ * editing/AlternativeTextController.h:
+ - Initialize m_isActive and m_isDismissedByEditing.
+
2021-04-02 Chris Dumez <[email protected]>
Make sure we are no longer show the previous page when running a JS prompt
Modified: trunk/Source/WebCore/editing/AlternativeTextController.h (275435 => 275436)
--- trunk/Source/WebCore/editing/AlternativeTextController.h 2021-04-02 20:23:26 UTC (rev 275435)
+++ trunk/Source/WebCore/editing/AlternativeTextController.h 2021-04-02 21:04:53 UTC (rev 275436)
@@ -1,5 +1,5 @@
/*
- * Copyright (C) 2010-2017 Apple Inc. All rights reserved.
+ * Copyright (C) 2010-2021 Apple Inc. All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
* modification, are permitted provided that the following conditions
@@ -121,8 +121,8 @@
Timer m_timer;
Optional<SimpleRange> m_rangeWithAlternative;
- bool m_isActive;
- bool m_isDismissedByEditing;
+ bool m_isActive { };
+ bool m_isDismissedByEditing { };
AlternativeTextType m_type;
String m_originalText;
Variant<AutocorrectionReplacement, DictationContext> m_details;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes