Title: [275448] trunk/Source/WebKit
Revision
275448
Author
[email protected]
Date
2021-04-02 15:44:37 -0700 (Fri, 02 Apr 2021)

Log Message

[GPUP] Power regression: audio hardware is configured for 128 frame preferred buffer size during VideoAudio playback
https://bugs.webkit.org/show_bug.cgi?id=224122

Reviewed by Eric Carlson.

The RemoteAudioHardwareListenerProxy tracks when audio hardware changes, and updates the WebContent process with
the supported properies of the new default audio device, including supported buffer sizes. However, it only does
so when the current audio devices changes, and not initially. Instead, ensure the WebContent process is immediately
update with the correct values for supported buffer sizes. This allows VideoAudio playback to enter a lower-power
playback mode by specifying a large preferred buffer size (4096).

* GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp:
(WebKit::RemoteAudioHardwareListenerProxy::RemoteAudioHardwareListenerProxy):

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (275447 => 275448)


--- trunk/Source/WebKit/ChangeLog	2021-04-02 22:39:22 UTC (rev 275447)
+++ trunk/Source/WebKit/ChangeLog	2021-04-02 22:44:37 UTC (rev 275448)
@@ -1,3 +1,19 @@
+2021-04-02  Jer Noble  <[email protected]>
+
+        [GPUP] Power regression: audio hardware is configured for 128 frame preferred buffer size during VideoAudio playback
+        https://bugs.webkit.org/show_bug.cgi?id=224122
+
+        Reviewed by Eric Carlson.
+
+        The RemoteAudioHardwareListenerProxy tracks when audio hardware changes, and updates the WebContent process with
+        the supported properies of the new default audio device, including supported buffer sizes. However, it only does
+        so when the current audio devices changes, and not initially. Instead, ensure the WebContent process is immediately
+        update with the correct values for supported buffer sizes. This allows VideoAudio playback to enter a lower-power
+        playback mode by specifying a large preferred buffer size (4096).
+
+        * GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp:
+        (WebKit::RemoteAudioHardwareListenerProxy::RemoteAudioHardwareListenerProxy):
+
 2021-04-02  Brady Eidson  <[email protected]>
 
         Add WKURLSchemeTask redirect API.

Modified: trunk/Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp (275447 => 275448)


--- trunk/Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp	2021-04-02 22:39:22 UTC (rev 275447)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteAudioHardwareListenerProxy.cpp	2021-04-02 22:44:37 UTC (rev 275448)
@@ -38,6 +38,7 @@
     , m_identifier(WTFMove(identifier))
     , m_listener(WebCore::AudioHardwareListener::create(*this))
 {
+    audioOutputDeviceChanged();
 }
 
 RemoteAudioHardwareListenerProxy::~RemoteAudioHardwareListenerProxy() = default;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to