Title: [275451] trunk/Source/WebKit
- Revision
- 275451
- Author
- [email protected]
- Date
- 2021-04-05 16:43:41 -0700 (Mon, 05 Apr 2021)
Log Message
[GPUP][iPad] Audio only when airplaying a youtube video
https://bugs.webkit.org/show_bug.cgi?id=224132
Reviewed by Eric Carlson.
While `MediaPlayerPrivateAVFoundationObjC` only implements `setWirelessPlaybackTarget()`
on macOS, `MediaPlayerPrivateMediaSourceAVFObjC` implements it on both macOS and iOS.
Therefore, `RemoteMediaPlayerProxy` has to forward the calls of `setWirelessPlaybackTarget()`
from WebContent processes to "MediaPlayerPrivate*" on both macOS and iOS.
Manually tested.
* GPUProcess/media/RemoteMediaPlayerProxy.cpp:
(WebKit::RemoteMediaPlayerProxy::setWirelessPlaybackTarget):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (275450 => 275451)
--- trunk/Source/WebKit/ChangeLog 2021-04-02 23:27:29 UTC (rev 275450)
+++ trunk/Source/WebKit/ChangeLog 2021-04-05 23:43:41 UTC (rev 275451)
@@ -1,3 +1,20 @@
+2021-04-05 Peng Liu <[email protected]>
+
+ [GPUP][iPad] Audio only when airplaying a youtube video
+ https://bugs.webkit.org/show_bug.cgi?id=224132
+
+ Reviewed by Eric Carlson.
+
+ While `MediaPlayerPrivateAVFoundationObjC` only implements `setWirelessPlaybackTarget()`
+ on macOS, `MediaPlayerPrivateMediaSourceAVFObjC` implements it on both macOS and iOS.
+ Therefore, `RemoteMediaPlayerProxy` has to forward the calls of `setWirelessPlaybackTarget()`
+ from WebContent processes to "MediaPlayerPrivate*" on both macOS and iOS.
+
+ Manually tested.
+
+ * GPUProcess/media/RemoteMediaPlayerProxy.cpp:
+ (WebKit::RemoteMediaPlayerProxy::setWirelessPlaybackTarget):
+
2021-04-02 Jer Noble <[email protected]>
[GPUP] Power regression: audio hardware is configured for 128 frame preferred buffer size during VideoAudio playback
Modified: trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp (275450 => 275451)
--- trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp 2021-04-02 23:27:29 UTC (rev 275450)
+++ trunk/Source/WebKit/GPUProcess/media/RemoteMediaPlayerProxy.cpp 2021-04-05 23:43:41 UTC (rev 275451)
@@ -699,21 +699,21 @@
void RemoteMediaPlayerProxy::setWirelessPlaybackTarget(const WebCore::MediaPlaybackTargetContext& targetContext)
{
-#if !PLATFORM(IOS_FAMILY)
switch (targetContext.type()) {
case MediaPlaybackTargetContext::AVOutputContextType:
m_player->setWirelessPlaybackTarget(WebCore::MediaPlaybackTargetCocoa::create(targetContext.avOutputContext()));
break;
+#if PLATFORM(MAC)
case MediaPlaybackTargetContext::MockType:
m_player->setWirelessPlaybackTarget(WebCore::MediaPlaybackTargetMock::create(targetContext.mockDeviceName(), targetContext.mockState()));
break;
+#else
+ case MediaPlaybackTargetContext::MockType:
+#endif
case MediaPlaybackTargetContext::None:
ASSERT_NOT_REACHED();
break;
}
-#else
- UNUSED_PARAM(targetContext);
-#endif
}
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
