Title: [275612] trunk/Tools
- Revision
- 275612
- Author
- [email protected]
- Date
- 2021-04-07 10:26:03 -0700 (Wed, 07 Apr 2021)
Log Message
git-webkit find doesn't work well with unicode characters in author name
https://bugs.webkit.org/show_bug.cgi?id=223686
Reviewed by Jonathan Bedard.
* Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:
(Info.main): Added a try except block while printing author, since the script should still print rest of the info.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (275611 => 275612)
--- trunk/Tools/ChangeLog 2021-04-07 17:08:35 UTC (rev 275611)
+++ trunk/Tools/ChangeLog 2021-04-07 17:26:03 UTC (rev 275612)
@@ -1,3 +1,13 @@
+2021-04-07 Aakash Jain <[email protected]>
+
+ git-webkit find doesn't work well with unicode characters in author name
+ https://bugs.webkit.org/show_bug.cgi?id=223686
+
+ Reviewed by Jonathan Bedard.
+
+ * Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py:
+ (Info.main): Added a try except block while printing author, since the script should still print rest of the info.
+
2021-04-07 Jonathan Bedard <[email protected]>
REGRESSION(r274366): webkitscmpy.test.svn_unittest.TestRemoteSvn.test_info fails in non-PDT timezones
Modified: trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py (275611 => 275612)
--- trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py 2021-04-07 17:08:35 UTC (rev 275611)
+++ trunk/Tools/Scripts/libraries/webkitscmpy/webkitscmpy/program/find.py 2021-04-07 17:26:03 UTC (rev 275612)
@@ -84,7 +84,10 @@
if commit.message:
print(u'Title: {}'.format(commit.message.splitlines()[0]))
- print(u'Author: {}'.format(commit.author))
+ try:
+ print(u'Author: {}'.format(commit.author))
+ except (UnicodeEncodeError, UnicodeDecodeError):
+ print('Author: ?')
print(datetime.fromtimestamp(commit.timestamp).strftime('Date: %a %b %d %H:%M:%S %Y'))
if args.verbose > 0 or commit.revision:
print('Revision: {}'.format(commit.revision or 'N/A'))
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
