Title: [275625] trunk/Source/WebKit
- Revision
- 275625
- Author
- [email protected]
- Date
- 2021-04-07 14:02:17 -0700 (Wed, 07 Apr 2021)
Log Message
[Cocoa] Incorrect selector used to set logging level
https://bugs.webkit.org/show_bug.cgi?id=224292
<rdar://problem/75379660>
Reviewed by John Wilander.
Use {public} declarations so we get logging in release builds. These strings
are not sensitive.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (275624 => 275625)
--- trunk/Source/WebKit/ChangeLog 2021-04-07 21:00:24 UTC (rev 275624)
+++ trunk/Source/WebKit/ChangeLog 2021-04-07 21:02:17 UTC (rev 275625)
@@ -6,6 +6,20 @@
Reviewed by John Wilander.
+ Use {public} declarations so we get logging in release builds. These strings
+ are not sensitive.
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (WebKit::configurationForSessionID):
+
+2021-04-07 Brent Fulgham <[email protected]>
+
+ [Cocoa] Incorrect selector used to set logging level
+ https://bugs.webkit.org/show_bug.cgi?id=224292
+ <rdar://problem/75379660>
+
+ Reviewed by John Wilander.
+
The wrong selector label was used to configure the low-level network logging level.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (275624 => 275625)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-04-07 21:00:24 UTC (rev 275624)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-04-07 21:02:17 UTC (rev 275625)
@@ -1043,7 +1043,7 @@
auto setLoggingPrivacyLevel = NSSelectorFromString(@"set_loggingPrivacyLevel:");
if ([configuration respondsToSelector:setLoggingPrivacyLevel]) {
wtfObjCMsgSend<void>(configuration, setLoggingPrivacyLevel, loggingPrivacyLevel);
- RELEASE_LOG(NetworkSession, "Setting logging level for %s session %" PRIu64 " to %s", session.isEphemeral() ? "Ephemeral" : "Regular", session.toUInt64(), loggingPrivacyLevel == nw_context_privacy_level_silent ? "silent" : "sensitive");
+ RELEASE_LOG(NetworkSession, "Setting logging level for %{public}s session %" PRIu64 " to %{public}s", session.isEphemeral() ? "Ephemeral" : "Regular", session.toUInt64(), loggingPrivacyLevel == nw_context_privacy_level_silent ? "silent" : "sensitive");
}
#elif HAVE(ALLOWS_SENSITIVE_LOGGING)
ALLOW_DEPRECATED_DECLARATIONS_BEGIN
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
