Title: [275784] trunk/Source/WebKit
- Revision
- 275784
- Author
- [email protected]
- Date
- 2021-04-09 16:54:17 -0700 (Fri, 09 Apr 2021)
Log Message
Unreviewed, fix for test crashes after r275779.
https://bugs.webkit.org/show_bug.cgi?id=224305
rdar://71962196
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::createWebIDBServer): hitting an assertion when deref the WeakPtr, so rolling back to
old impl.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (275783 => 275784)
--- trunk/Source/WebKit/ChangeLog 2021-04-09 23:33:30 UTC (rev 275783)
+++ trunk/Source/WebKit/ChangeLog 2021-04-09 23:54:17 UTC (rev 275784)
@@ -1,3 +1,13 @@
+2021-04-09 Sihui Liu <[email protected]>
+
+ Unreviewed, fix for test crashes after r275779.
+ https://bugs.webkit.org/show_bug.cgi?id=224305
+ rdar://71962196
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::createWebIDBServer): hitting an assertion when deref the WeakPtr, so rolling back to
+ old impl.
+
2021-04-09 Jer Noble <[email protected]>
[Cocoa] Don't set LD_RUNPATH_SEARCH_PATHS in the WebKit project file.
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (275783 => 275784)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-04-09 23:33:30 UTC (rev 275783)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-04-09 23:54:17 UTC (rev 275784)
@@ -2326,9 +2326,8 @@
path = m_idbDatabasePaths.get(sessionID);
}
- auto spaceRequester = [weakThis = makeWeakPtr(this), sessionID](const auto& origin, uint64_t spaceRequested) {
- auto protectedThis = makeRefPtr(weakThis.get());
- RefPtr<StorageQuotaManager> storageQuotaManager = protectedThis? protectedThis->storageQuotaManager(sessionID, origin) : nullptr;
+ auto spaceRequester = [this, weakThis = makeWeakPtr(this), sessionID](const auto& origin, uint64_t spaceRequested) {
+ RefPtr<StorageQuotaManager> storageQuotaManager = weakThis ? this->storageQuotaManager(sessionID, origin) : nullptr;
return storageQuotaManager ? storageQuotaManager->requestSpaceOnBackgroundThread(spaceRequested) : StorageQuotaManager::Decision::Deny;
};
auto closeHandler = [weakThis = makeWeakPtr(this), sessionID]() {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
