Title: [275822] trunk/LayoutTests
Revision
275822
Author
[email protected]
Date
2021-04-12 06:52:02 -0700 (Mon, 12 Apr 2021)

Log Message

[ macOS wk2 ] webrtc/libwebrtc/release-while-creating-offer.html is a flakey text failure
https://bugs.webkit.org/show_bug.cgi?id=224256
<rdar://problem/76296126>

Reviewed by Eric Carlson.

Pass a valid candidate to remove the rejection message.

* platform/mac-wk2/TestExpectations:
* webrtc/libwebrtc/release-while-creating-offer-expected.txt:
* webrtc/libwebrtc/release-while-creating-offer.html:
* webrtc/libwebrtc/release-while-setting-local-description.html:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (275821 => 275822)


--- trunk/LayoutTests/ChangeLog	2021-04-12 13:41:38 UTC (rev 275821)
+++ trunk/LayoutTests/ChangeLog	2021-04-12 13:52:02 UTC (rev 275822)
@@ -1,3 +1,18 @@
+2021-04-12  Youenn Fablet  <[email protected]>
+
+        [ macOS wk2 ] webrtc/libwebrtc/release-while-creating-offer.html is a flakey text failure
+        https://bugs.webkit.org/show_bug.cgi?id=224256
+        <rdar://problem/76296126>
+
+        Reviewed by Eric Carlson.
+
+        Pass a valid candidate to remove the rejection message.
+
+        * platform/mac-wk2/TestExpectations:
+        * webrtc/libwebrtc/release-while-creating-offer-expected.txt:
+        * webrtc/libwebrtc/release-while-creating-offer.html:
+        * webrtc/libwebrtc/release-while-setting-local-description.html:
+
 2021-04-12  Philippe Normand  <[email protected]>
 
         [MSE][GStreamer] Crash in WebCore::PlaybackPipeline::addSourceBuffer when setting duration and preload is set to none

Modified: trunk/LayoutTests/platform/mac-wk2/TestExpectations (275821 => 275822)


--- trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-04-12 13:41:38 UTC (rev 275821)
+++ trunk/LayoutTests/platform/mac-wk2/TestExpectations	2021-04-12 13:52:02 UTC (rev 275822)
@@ -1369,6 +1369,4 @@
 
 webkit.org/b/224135 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass Timeout ]
 
-webkit.org/b/224256 webrtc/libwebrtc/release-while-creating-offer.html [ Pass Failure ]
-
-webkit.org/b/224294 [ Debug ] inspector/indexeddb/requestDatabaseNames.html [ Pass Failure ]
\ No newline at end of file
+webkit.org/b/224294 [ Debug ] inspector/indexeddb/requestDatabaseNames.html [ Pass Failure ]

Modified: trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer-expected.txt (275821 => 275822)


--- trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer-expected.txt	2021-04-12 13:41:38 UTC (rev 275821)
+++ trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer-expected.txt	2021-04-12 13:52:02 UTC (rev 275822)
@@ -1,4 +1,3 @@
-CONSOLE MESSAGE: Unhandled Promise Rejection: TypeError: Candidate must not have both null sdpMid and sdpMLineIndex
 PASS successfullyParsed is true
 
 TEST COMPLETE

Modified: trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer.html (275821 => 275822)


--- trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer.html	2021-04-12 13:41:38 UTC (rev 275821)
+++ trunk/LayoutTests/webrtc/libwebrtc/release-while-creating-offer.html	2021-04-12 13:52:02 UTC (rev 275822)
@@ -12,7 +12,7 @@
 
 (function() {
     var pc = new RTCPeerConnection();
-    pc.addIceCandidate({ candidate : "2013266431 1 udp 2013266432 192.168.0.100 38838 typ host generation 0" });
+    pc.addIceCandidate({ candidate : "2013266431 1 udp 2013266432 192.168.0.100 38838 typ host generation 0", sdpMid: "0", sdpMLineIndex: 0 });
     pc.createOffer();
     pc.close();
 })();

Modified: trunk/LayoutTests/webrtc/libwebrtc/release-while-setting-local-description.html (275821 => 275822)


--- trunk/LayoutTests/webrtc/libwebrtc/release-while-setting-local-description.html	2021-04-12 13:41:38 UTC (rev 275821)
+++ trunk/LayoutTests/webrtc/libwebrtc/release-while-setting-local-description.html	2021-04-12 13:52:02 UTC (rev 275822)
@@ -15,7 +15,7 @@
 
 (function() {
     var pc = new RTCPeerConnection();
-    pc.addIceCandidate({ candidate : "2013266431 1 udp 2013266432 192.168.0.100 38838 typ host generation 0" });
+    pc.addIceCandidate({ candidate : "2013266431 1 udp 2013266432 192.168.0.100 38838 typ host generation 0", sdpMid: "0", sdpMLineIndex: 0 });
     pc.createOffer().then((offer) => {
         setTimeout(function() {
             if (window.GCController)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to