Title: [275850] trunk/Source/_javascript_Core
- Revision
- 275850
- Author
- [email protected]
- Date
- 2021-04-12 17:36:28 -0700 (Mon, 12 Apr 2021)
Log Message
Inspector code is wrongly including some private headers
https://bugs.webkit.org/show_bug.cgi?id=224456
Reviewed by Alex Christensen.
These files were including some headers using #include <_javascript_Core/Foo.h> style instead
of "Foo.h" style. This caused a build error when attempting to revive the Mac CMake build
since those headers were private and private headers are generated after the _javascript_Core
build. No other ports were have ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS turned on so the
issue hadn't manifested until now.
* API/JSContextRefInspectorSupport.h:
* inspector/augmentable/AlternateDispatchableAgent.h:
* inspector/augmentable/AugmentableInspectorController.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/API/JSContextRefInspectorSupport.h (275849 => 275850)
--- trunk/Source/_javascript_Core/API/JSContextRefInspectorSupport.h 2021-04-13 00:33:00 UTC (rev 275849)
+++ trunk/Source/_javascript_Core/API/JSContextRefInspectorSupport.h 2021-04-13 00:36:28 UTC (rev 275850)
@@ -30,7 +30,7 @@
#error Requires C++ Support.
#endif
-#include <_javascript_Core/JSContextRefPrivate.h>
+#include "JSContextRefPrivate.h"
namespace Inspector {
class AugmentableInspectorController;
Modified: trunk/Source/_javascript_Core/ChangeLog (275849 => 275850)
--- trunk/Source/_javascript_Core/ChangeLog 2021-04-13 00:33:00 UTC (rev 275849)
+++ trunk/Source/_javascript_Core/ChangeLog 2021-04-13 00:36:28 UTC (rev 275850)
@@ -1,3 +1,20 @@
+2021-04-12 Don Olmstead <[email protected]>
+
+ Inspector code is wrongly including some private headers
+ https://bugs.webkit.org/show_bug.cgi?id=224456
+
+ Reviewed by Alex Christensen.
+
+ These files were including some headers using #include <_javascript_Core/Foo.h> style instead
+ of "Foo.h" style. This caused a build error when attempting to revive the Mac CMake build
+ since those headers were private and private headers are generated after the _javascript_Core
+ build. No other ports were have ENABLE_INSPECTOR_ALTERNATE_DISPATCHERS turned on so the
+ issue hadn't manifested until now.
+
+ * API/JSContextRefInspectorSupport.h:
+ * inspector/augmentable/AlternateDispatchableAgent.h:
+ * inspector/augmentable/AugmentableInspectorController.h:
+
2021-04-12 BJ Burg <[email protected]>
Modernize uses of ConsoleClient
Modified: trunk/Source/_javascript_Core/inspector/augmentable/AlternateDispatchableAgent.h (275849 => 275850)
--- trunk/Source/_javascript_Core/inspector/augmentable/AlternateDispatchableAgent.h 2021-04-13 00:33:00 UTC (rev 275849)
+++ trunk/Source/_javascript_Core/inspector/augmentable/AlternateDispatchableAgent.h 2021-04-13 00:36:28 UTC (rev 275850)
@@ -27,8 +27,8 @@
#if ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
+#include "InspectorAgentBase.h"
#include "InspectorAlternateBackendDispatchers.h"
-#include <_javascript_Core/InspectorAgentBase.h>
#include <wtf/Forward.h>
namespace Inspector {
Modified: trunk/Source/_javascript_Core/inspector/augmentable/AugmentableInspectorController.h (275849 => 275850)
--- trunk/Source/_javascript_Core/inspector/augmentable/AugmentableInspectorController.h 2021-04-13 00:33:00 UTC (rev 275849)
+++ trunk/Source/_javascript_Core/inspector/augmentable/AugmentableInspectorController.h 2021-04-13 00:36:28 UTC (rev 275850)
@@ -27,9 +27,9 @@
#if ENABLE(INSPECTOR_ALTERNATE_DISPATCHERS)
-#include <_javascript_Core/AugmentableInspectorControllerClient.h>
-#include <_javascript_Core/InspectorBackendDispatcher.h>
-#include <_javascript_Core/InspectorFrontendRouter.h>
+#include "AugmentableInspectorControllerClient.h"
+#include "InspectorBackendDispatcher.h"
+#include "InspectorFrontendRouter.h"
namespace Inspector {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
