Title: [275852] trunk/Source/WebCore
- Revision
- 275852
- Author
- [email protected]
- Date
- 2021-04-12 17:47:20 -0700 (Mon, 12 Apr 2021)
Log Message
Unreviewed, reverting r275761.
Caused InlineBox invalidation bugs.
Reverted changeset:
"[RenderTreeBuilder] Cleanup the inline box wrappers when
moving subtrees"
https://bugs.webkit.org/show_bug.cgi?id=224342
https://commits.webkit.org/r275761
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (275851 => 275852)
--- trunk/Source/WebCore/ChangeLog 2021-04-13 00:45:41 UTC (rev 275851)
+++ trunk/Source/WebCore/ChangeLog 2021-04-13 00:47:20 UTC (rev 275852)
@@ -1,3 +1,16 @@
+2021-04-12 Zalan Bujtas <[email protected]>
+
+ Unreviewed, reverting r275761.
+
+ Caused InlineBox invalidation bugs.
+
+ Reverted changeset:
+
+ "[RenderTreeBuilder] Cleanup the inline box wrappers when
+ moving subtrees"
+ https://bugs.webkit.org/show_bug.cgi?id=224342
+ https://commits.webkit.org/r275761
+
2021-04-12 BJ Burg <[email protected]>
Modernize uses of ConsoleClient
Modified: trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp (275851 => 275852)
--- trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp 2021-04-13 00:45:41 UTC (rev 275851)
+++ trunk/Source/WebCore/rendering/updating/RenderTreeBuilder.cpp 2021-04-13 00:47:20 UTC (rev 275852)
@@ -486,12 +486,6 @@
auto childToMove = detachFromRenderElement(from, child, WillBeDestroyed::No, RenderObject::IsInternalMove::Yes);
attachToRenderElementInternal(to, WTFMove(childToMove), beforeChild, RenderObject::IsInternalMove::Yes);
}
- if (is<RenderInline>(child)) {
- // When moving a subtree out of a BFC we need to make sure that the line boxes generated for the inline tree are not accessible anymore from the renderers.
- // They eventually get destroyed during the inline layout of the original BFC.
- for (auto& descendant : descendantsOfType<RenderBox>(downcast<RenderInline>(child)))
- descendant.setInlineBoxWrapper(nullptr);
- }
}
void RenderTreeBuilder::move(RenderBoxModelObject& from, RenderBoxModelObject& to, RenderObject& child, NormalizeAfterInsertion normalizeAfterInsertion)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
