Title: [105825] trunk/Source/WebCore
- Revision
- 105825
- Author
- [email protected]
- Date
- 2012-01-24 15:46:49 -0800 (Tue, 24 Jan 2012)
Log Message
Make DataTransferItemList::length() const.
https://bugs.webkit.org/show_bug.cgi?id=76946
Just a const-correctness change.
Reviewed by Tony Chang.
No new tests since no functionality changed.
* dom/DataTransferItemList.h:
(DataTransferItemList):
* platform/chromium/DataTransferItemListChromium.cpp:
(WebCore::DataTransferItemListChromium::length):
* platform/chromium/DataTransferItemListChromium.h:
(DataTransferItemListChromium):
* platform/qt/DataTransferItemListQt.cpp:
(WebCore::DataTransferItemListQt::length):
* platform/qt/DataTransferItemListQt.h:
(DataTransferItemListQt):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (105824 => 105825)
--- trunk/Source/WebCore/ChangeLog 2012-01-24 23:37:47 UTC (rev 105824)
+++ trunk/Source/WebCore/ChangeLog 2012-01-24 23:46:49 UTC (rev 105825)
@@ -1,3 +1,25 @@
+2012-01-24 Daniel Cheng <[email protected]>
+
+ Make DataTransferItemList::length() const.
+ https://bugs.webkit.org/show_bug.cgi?id=76946
+
+ Just a const-correctness change.
+
+ Reviewed by Tony Chang.
+
+ No new tests since no functionality changed.
+
+ * dom/DataTransferItemList.h:
+ (DataTransferItemList):
+ * platform/chromium/DataTransferItemListChromium.cpp:
+ (WebCore::DataTransferItemListChromium::length):
+ * platform/chromium/DataTransferItemListChromium.h:
+ (DataTransferItemListChromium):
+ * platform/qt/DataTransferItemListQt.cpp:
+ (WebCore::DataTransferItemListQt::length):
+ * platform/qt/DataTransferItemListQt.h:
+ (DataTransferItemListQt):
+
2012-01-24 Tony Chang <[email protected]>
REGRESSION(r103245): can't scroll left/up using scrollbar controls of overflowing elements
Modified: trunk/Source/WebCore/dom/DataTransferItemList.h (105824 => 105825)
--- trunk/Source/WebCore/dom/DataTransferItemList.h 2012-01-24 23:37:47 UTC (rev 105824)
+++ trunk/Source/WebCore/dom/DataTransferItemList.h 2012-01-24 23:46:49 UTC (rev 105825)
@@ -48,7 +48,7 @@
public:
virtual ~DataTransferItemList() { }
- virtual size_t length() = 0;
+ virtual size_t length() const = 0;
virtual PassRefPtr<DataTransferItem> item(unsigned long index) = 0;
virtual void deleteItem(unsigned long index, ExceptionCode&) = 0;
virtual void clear() = 0;
Modified: trunk/Source/WebCore/platform/chromium/DataTransferItemListChromium.cpp (105824 => 105825)
--- trunk/Source/WebCore/platform/chromium/DataTransferItemListChromium.cpp 2012-01-24 23:37:47 UTC (rev 105824)
+++ trunk/Source/WebCore/platform/chromium/DataTransferItemListChromium.cpp 2012-01-24 23:46:49 UTC (rev 105825)
@@ -58,7 +58,7 @@
{
}
-size_t DataTransferItemListChromium::length()
+size_t DataTransferItemListChromium::length() const
{
if (m_owner->policy() == ClipboardNumb)
return 0;
Modified: trunk/Source/WebCore/platform/chromium/DataTransferItemListChromium.h (105824 => 105825)
--- trunk/Source/WebCore/platform/chromium/DataTransferItemListChromium.h 2012-01-24 23:37:47 UTC (rev 105824)
+++ trunk/Source/WebCore/platform/chromium/DataTransferItemListChromium.h 2012-01-24 23:46:49 UTC (rev 105825)
@@ -50,7 +50,7 @@
public:
static PassRefPtr<DataTransferItemListChromium> create(PassRefPtr<Clipboard>, ScriptExecutionContext*);
- virtual size_t length();
+ virtual size_t length() const;
virtual PassRefPtr<DataTransferItem> item(unsigned long index);
// FIXME: Implement V8DataTransferItemList::indexedPropertyDeleter to get this called.
virtual void deleteItem(unsigned long index, ExceptionCode&);
@@ -65,7 +65,8 @@
RefPtr<Clipboard> m_owner;
// Indirectly owned by our parent.
ScriptExecutionContext* m_context;
- Vector<RefPtr<DataTransferItem> > m_items;
+ // FIXME: m_items should not be mutable. This will be fixed by https://bugs.webkit.org/show_bug.cgi?id=76598
+ mutable Vector<RefPtr<DataTransferItem> > m_items;
};
} // namespace WebCore
Modified: trunk/Source/WebCore/platform/qt/DataTransferItemListQt.cpp (105824 => 105825)
--- trunk/Source/WebCore/platform/qt/DataTransferItemListQt.cpp 2012-01-24 23:37:47 UTC (rev 105824)
+++ trunk/Source/WebCore/platform/qt/DataTransferItemListQt.cpp 2012-01-24 23:46:49 UTC (rev 105825)
@@ -45,7 +45,7 @@
{
}
-size_t DataTransferItemListQt::length()
+size_t DataTransferItemListQt::length() const
{
if (m_owner->policy() == ClipboardNumb)
return 0;
Modified: trunk/Source/WebCore/platform/qt/DataTransferItemListQt.h (105824 => 105825)
--- trunk/Source/WebCore/platform/qt/DataTransferItemListQt.h 2012-01-24 23:37:47 UTC (rev 105824)
+++ trunk/Source/WebCore/platform/qt/DataTransferItemListQt.h 2012-01-24 23:46:49 UTC (rev 105825)
@@ -42,7 +42,7 @@
public:
static PassRefPtr<DataTransferItemListQt> create(PassRefPtr<Clipboard>, ScriptExecutionContext*);
- virtual size_t length();
+ virtual size_t length() const;
virtual PassRefPtr<DataTransferItem> item(unsigned long index);
virtual void deleteItem(unsigned long index, ExceptionCode&);
virtual void clear();
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes
