Title: [275945] trunk/Source/WebCore
- Revision
- 275945
- Author
- [email protected]
- Date
- 2021-04-14 08:42:17 -0700 (Wed, 14 Apr 2021)
Log Message
Remove unused InlineBox::next/previousLeafOnLineIgnoringLineBreak()
https://bugs.webkit.org/show_bug.cgi?id=224542
Reviewed by Zalan Bujtas.
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nextLeafOnLineIgnoringLineBreak const): Deleted.
(WebCore::InlineBox::previousLeafOnLineIgnoringLineBreak const): Deleted.
* rendering/InlineBox.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (275944 => 275945)
--- trunk/Source/WebCore/ChangeLog 2021-04-14 15:13:36 UTC (rev 275944)
+++ trunk/Source/WebCore/ChangeLog 2021-04-14 15:42:17 UTC (rev 275945)
@@ -1,3 +1,15 @@
+2021-04-14 Antti Koivisto <[email protected]>
+
+ Remove unused InlineBox::next/previousLeafOnLineIgnoringLineBreak()
+ https://bugs.webkit.org/show_bug.cgi?id=224542
+
+ Reviewed by Zalan Bujtas.
+
+ * rendering/InlineBox.cpp:
+ (WebCore::InlineBox::nextLeafOnLineIgnoringLineBreak const): Deleted.
+ (WebCore::InlineBox::previousLeafOnLineIgnoringLineBreak const): Deleted.
+ * rendering/InlineBox.h:
+
2021-04-14 Frédéric Wang <[email protected]>
Crash in RenderBlock::addOverflowFromChildren
Modified: trunk/Source/WebCore/rendering/InlineBox.cpp (275944 => 275945)
--- trunk/Source/WebCore/rendering/InlineBox.cpp 2021-04-14 15:13:36 UTC (rev 275944)
+++ trunk/Source/WebCore/rendering/InlineBox.cpp 2021-04-14 15:42:17 UTC (rev 275945)
@@ -242,22 +242,6 @@
return leaf;
}
-InlineBox* InlineBox::nextLeafOnLineIgnoringLineBreak() const
-{
- InlineBox* leaf = nextLeafOnLine();
- if (leaf && leaf->isLineBreak())
- return nullptr;
- return leaf;
-}
-
-InlineBox* InlineBox::previousLeafOnLineIgnoringLineBreak() const
-{
- InlineBox* leaf = previousLeafOnLine();
- if (leaf && leaf->isLineBreak())
- return nullptr;
- return leaf;
-}
-
RenderObject::HighlightState InlineBox::selectionState()
{
return renderer().selectionState();
Modified: trunk/Source/WebCore/rendering/InlineBox.h (275944 => 275945)
--- trunk/Source/WebCore/rendering/InlineBox.h 2021-04-14 15:13:36 UTC (rev 275944)
+++ trunk/Source/WebCore/rendering/InlineBox.h 2021-04-14 15:42:17 UTC (rev 275945)
@@ -135,12 +135,6 @@
InlineBox* nextLeafOnLine() const;
InlineBox* previousLeafOnLine() const;
- // Helper functions for editing and hit-testing code.
- // FIXME: These two functions should be moved to RenderedPosition once the code to convert between
- // Position and inline box, offset pair is moved to RenderedPosition.
- InlineBox* nextLeafOnLineIgnoringLineBreak() const;
- InlineBox* previousLeafOnLineIgnoringLineBreak() const;
-
// FIXME: Hide this once all callers are using tighter types.
RenderObject& renderer() const { return *m_renderer; }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes