Title: [276244] trunk/Source/WebCore
- Revision
- 276244
- Author
- [email protected]
- Date
- 2021-04-19 02:56:09 -0700 (Mon, 19 Apr 2021)
Log Message
Move from RecursiveLock to Lock in RealtimeMediaSource
https://bugs.webkit.org/show_bug.cgi?id=224671
Reviewed by Eric Carlson.
RecursiveLock is more expensive as it allocates memory and not useful here.
Covered by existing tests.
* platform/mediastream/RealtimeMediaSource.h:
* platform/mediastream/RealtimeOutgoingAudioSource.h:
* platform/mediastream/RealtimeOutgoingVideoSource.h:
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276243 => 276244)
--- trunk/Source/WebCore/ChangeLog 2021-04-19 09:53:37 UTC (rev 276243)
+++ trunk/Source/WebCore/ChangeLog 2021-04-19 09:56:09 UTC (rev 276244)
@@ -1,5 +1,19 @@
2021-04-19 Youenn Fablet <[email protected]>
+ Move from RecursiveLock to Lock in RealtimeMediaSource
+ https://bugs.webkit.org/show_bug.cgi?id=224671
+
+ Reviewed by Eric Carlson.
+
+ RecursiveLock is more expensive as it allocates memory and not useful here.
+ Covered by existing tests.
+
+ * platform/mediastream/RealtimeMediaSource.h:
+ * platform/mediastream/RealtimeOutgoingAudioSource.h:
+ * platform/mediastream/RealtimeOutgoingVideoSource.h:
+
+2021-04-19 Youenn Fablet <[email protected]>
+
Reduce crackling at start of playing a live audio track
https://bugs.webkit.org/show_bug.cgi?id=218898
<rdar://problem/71625010>
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h (276243 => 276244)
--- trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2021-04-19 09:53:37 UTC (rev 276243)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeMediaSource.h 2021-04-19 09:56:09 UTC (rev 276244)
@@ -43,8 +43,8 @@
#include "RealtimeMediaSourceCapabilities.h"
#include "RealtimeMediaSourceFactory.h"
#include <wtf/CompletionHandler.h>
+#include <wtf/Lock.h>
#include <wtf/LoggerHelper.h>
-#include <wtf/RecursiveLockAdapter.h>
#include <wtf/ThreadSafeRefCounted.h>
#include <wtf/Vector.h>
#include <wtf/WeakHashSet.h>
@@ -276,10 +276,10 @@
String m_name;
WeakHashSet<Observer> m_observers;
- mutable RecursiveLock m_audioSampleObserversLock;
+ mutable Lock m_audioSampleObserversLock;
HashSet<AudioSampleObserver*> m_audioSampleObservers;
- mutable RecursiveLock m_videoSampleObserversLock;
+ mutable Lock m_videoSampleObserversLock;
HashSet<VideoSampleObserver*> m_videoSampleObservers;
// Set on the main thread from constraints.
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h (276243 => 276244)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2021-04-19 09:53:37 UTC (rev 276243)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingAudioSource.h 2021-04-19 09:56:09 UTC (rev 276244)
@@ -127,7 +127,7 @@
bool m_muted { false };
bool m_enabled { true };
- mutable RecursiveLock m_sinksLock;
+ mutable Lock m_sinksLock;
HashSet<webrtc::AudioTrackSinkInterface*> m_sinks;
#if !RELEASE_LOG_DISABLED
Modified: trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h (276243 => 276244)
--- trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h 2021-04-19 09:53:37 UTC (rev 276243)
+++ trunk/Source/WebCore/platform/mediastream/RealtimeOutgoingVideoSource.h 2021-04-19 09:56:09 UTC (rev 276244)
@@ -141,7 +141,7 @@
Timer m_blackFrameTimer;
rtc::scoped_refptr<webrtc::VideoFrameBuffer> m_blackFrame;
- mutable RecursiveLock m_sinksLock;
+ mutable Lock m_sinksLock;
HashSet<rtc::VideoSinkInterface<webrtc::VideoFrame>*> m_sinks;
bool m_areSinksAskingToApplyRotation { false };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
