Title: [276253] trunk/Source/WebCore
- Revision
- 276253
- Author
- [email protected]
- Date
- 2021-04-19 08:18:33 -0700 (Mon, 19 Apr 2021)
Log Message
Silence various -Wreturn-type warnings
https://bugs.webkit.org/show_bug.cgi?id=224756
Patch by Michael Catanzaro <[email protected]> on 2021-04-19
Reviewed by Don Olmstead.
* css/parser/CSSPropertyParserHelpers.cpp:
(WebCore::CSSPropertyParserHelpers::mixColorComponents):
* inspector/InspectorOverlay.cpp:
(WebCore::expectedSizeForLayoutLabel):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::usedClear):
(WebCore::RenderStyle::usedFloat):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276252 => 276253)
--- trunk/Source/WebCore/ChangeLog 2021-04-19 14:16:05 UTC (rev 276252)
+++ trunk/Source/WebCore/ChangeLog 2021-04-19 15:18:33 UTC (rev 276253)
@@ -1,3 +1,18 @@
+2021-04-19 Michael Catanzaro <[email protected]>
+
+ Silence various -Wreturn-type warnings
+ https://bugs.webkit.org/show_bug.cgi?id=224756
+
+ Reviewed by Don Olmstead.
+
+ * css/parser/CSSPropertyParserHelpers.cpp:
+ (WebCore::CSSPropertyParserHelpers::mixColorComponents):
+ * inspector/InspectorOverlay.cpp:
+ (WebCore::expectedSizeForLayoutLabel):
+ * rendering/style/RenderStyle.cpp:
+ (WebCore::RenderStyle::usedClear):
+ (WebCore::RenderStyle::usedFloat):
+
2021-04-19 Wenson Hsieh <[email protected]>
Unreviewed, fix the build after r276181
Modified: trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp (276252 => 276253)
--- trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2021-04-19 14:16:05 UTC (rev 276252)
+++ trunk/Source/WebCore/css/parser/CSSPropertyParserHelpers.cpp 2021-04-19 15:18:33 UTC (rev 276253)
@@ -1803,6 +1803,8 @@
case ColorMixColorSpace::Srgb:
return mixColorComponentsInColorSpace<SRGBA<float>>(mixPercentages, mixComponents1.color, mixComponents2.color);
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
static Color parseColorMixFunctionParameters(CSSParserTokenRange& range, const CSSParserContext& context)
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (276252 => 276253)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-04-19 14:16:05 UTC (rev 276252)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-04-19 15:18:33 UTC (rev 276253)
@@ -1363,6 +1363,8 @@
case InspectorOverlay::LabelArrowDirection::None:
return { textWidth + (layoutLabelPadding * 2), textHeight + (layoutLabelPadding * 2) };
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
void InspectorOverlay::drawLayoutLabel(GraphicsContext& context, String label, FloatPoint point, InspectorOverlay::LabelArrowDirection arrowDirection, InspectorOverlay::LabelArrowEdgePosition arrowEdgePosition, Color backgroundColor, float maximumWidth)
Modified: trunk/Source/WebCore/rendering/style/RenderStyle.cpp (276252 => 276253)
--- trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2021-04-19 14:16:05 UTC (rev 276252)
+++ trunk/Source/WebCore/rendering/style/RenderStyle.cpp 2021-04-19 15:18:33 UTC (rev 276253)
@@ -2684,6 +2684,8 @@
return computedValue == Clear::InlineStart ? UsedClear::Right : UsedClear::Left;
return computedValue == Clear::InlineStart ? UsedClear::Left : UsedClear::Right;
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
UsedFloat RenderStyle::usedFloat(const RenderObject& renderer)
@@ -2703,5 +2705,7 @@
return computedValue == Float::InlineStart ? UsedFloat::Right : UsedFloat::Left;
return computedValue == Float::InlineStart ? UsedFloat::Left : UsedFloat::Right;
}
+
+ RELEASE_ASSERT_NOT_REACHED();
}
} // namespace WebCore
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
