Title: [276265] trunk/Source/WebInspectorUI
- Revision
- 276265
- Author
- [email protected]
- Date
- 2021-04-19 11:21:54 -0700 (Mon, 19 Apr 2021)
Log Message
Web Inspector: REGRESSION(?): Network: Request (Object Tree) is sometimes empty
https://bugs.webkit.org/show_bug.cgi?id=224768
<rdar://problem/76783636>
Reviewed by BJ Burg.
* UserInterface/Views/LocalJSONContentView.js:
(WI.LocalJSONContentView.prototype.renderRemoteObject):
If the `WI.RemoteObject` is simple enough to be rendered inline, `WI.ObjectTreeView` won't
show a `WI.TreeOutline` by default. We have to tell it to use a `WI.TreeOutline` by passing
`forceExpanding = true` into the constructor.
* UserInterface/Views/ObjectTreeView.js:
(WI.ObjectTreeView.prototype.showOnlyJSON):
Add some `console.assert` to help prevent this from happening again.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (276264 => 276265)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-04-19 17:59:26 UTC (rev 276264)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-04-19 18:21:54 UTC (rev 276265)
@@ -1,3 +1,21 @@
+2021-04-19 Devin Rousso <[email protected]>
+
+ Web Inspector: REGRESSION(?): Network: Request (Object Tree) is sometimes empty
+ https://bugs.webkit.org/show_bug.cgi?id=224768
+ <rdar://problem/76783636>
+
+ Reviewed by BJ Burg.
+
+ * UserInterface/Views/LocalJSONContentView.js:
+ (WI.LocalJSONContentView.prototype.renderRemoteObject):
+ If the `WI.RemoteObject` is simple enough to be rendered inline, `WI.ObjectTreeView` won't
+ show a `WI.TreeOutline` by default. We have to tell it to use a `WI.TreeOutline` by passing
+ `forceExpanding = true` into the constructor.
+
+ * UserInterface/Views/ObjectTreeView.js:
+ (WI.ObjectTreeView.prototype.showOnlyJSON):
+ Add some `console.assert` to help prevent this from happening again.
+
2021-04-19 Kimmo Kinnunen <[email protected]>
Enable -Wthread-safety, add attributes to custom lock classes, and provide macros to declare guards
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LocalJSONContentView.js (276264 => 276265)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LocalJSONContentView.js 2021-04-19 17:59:26 UTC (rev 276264)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LocalJSONContentView.js 2021-04-19 18:21:54 UTC (rev 276265)
@@ -43,7 +43,9 @@
renderRemoteObject(remoteObject)
{
- let objectTree = new WI.ObjectTreeView(remoteObject);
+ const propertyPath = null;
+ const forceExpanding = true;
+ let objectTree = new WI.ObjectTreeView(remoteObject, WI.ObjectTreeView.Mode.Properties, propertyPath, forceExpanding);
objectTree.showOnlyJSON();
objectTree.expand();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js (276264 => 276265)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js 2021-04-19 17:59:26 UTC (rev 276264)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ObjectTreeView.js 2021-04-19 18:21:54 UTC (rev 276265)
@@ -295,6 +295,9 @@
showOnlyJSON()
{
+ console.assert(this._mode === WI.ObjectTreeView.Mode.Properties, this._mode);
+ console.assert(!this._hasLosslessPreview);
+
this.showOnlyProperties();
this._element.classList.add("json-only");
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
