Title: [276274] trunk/Source/WebCore
- Revision
- 276274
- Author
- [email protected]
- Date
- 2021-04-19 14:18:00 -0700 (Mon, 19 Apr 2021)
Log Message
Web Inspector: Grid overlay column line label placement copy/paste error
https://bugs.webkit.org/show_bug.cgi?id=224777
Reviewed by Devin Rousso.
In grid overlays, a typo meant for all column line labels after the initial line, only the start of the line was
used for placement, where it is more accurate to use the start and end points to match the behavior of the first
line. This had no visual impact because subsequent lines do not currently have their labels adjusted further into
the grid, only flipped into the grid but still referencing the same point. This patch corrects the value of
`gapLabelLine` to always be a line on which the label can be placed, instead of a single point.
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::buildGridOverlay):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276273 => 276274)
--- trunk/Source/WebCore/ChangeLog 2021-04-19 21:10:23 UTC (rev 276273)
+++ trunk/Source/WebCore/ChangeLog 2021-04-19 21:18:00 UTC (rev 276274)
@@ -1,3 +1,19 @@
+2021-04-19 Patrick Angle <[email protected]>
+
+ Web Inspector: Grid overlay column line label placement copy/paste error
+ https://bugs.webkit.org/show_bug.cgi?id=224777
+
+ Reviewed by Devin Rousso.
+
+ In grid overlays, a typo meant for all column line labels after the initial line, only the start of the line was
+ used for placement, where it is more accurate to use the start and end points to match the behavior of the first
+ line. This had no visual impact because subsequent lines do not currently have their labels adjusted further into
+ the grid, only flipped into the grid but still referencing the same point. This patch corrects the value of
+ `gapLabelLine` to always be a line on which the label can be placed, instead of a single point.
+
+ * inspector/InspectorOverlay.cpp:
+ (WebCore::InspectorOverlay::buildGridOverlay):
+
2021-04-19 Zalan Bujtas <[email protected]>
[LFC][IFC] LineCandidate.inlineContent should be ignored when reverting
Modified: trunk/Source/WebCore/inspector/InspectorOverlay.cpp (276273 => 276274)
--- trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-04-19 21:10:23 UTC (rev 276273)
+++ trunk/Source/WebCore/inspector/InspectorOverlay.cpp 2021-04-19 21:18:00 UTC (rev 276274)
@@ -1768,7 +1768,7 @@
gridHighlightOverlay.gaps.append({ previousColumnEndLine.start(), columnStartLine.start(), columnStartLine.end(), previousColumnEndLine.end() });
FloatLine lineBetweenColumnTops = { columnStartLine.start(), previousColumnEndLine.start() };
FloatLine lineBetweenColumnBottoms = { columnStartLine.end(), previousColumnEndLine.end() };
- gapLabelLine = { lineBetweenColumnTops.pointAtRelativeDistance(0.5), lineBetweenColumnTops.pointAtRelativeDistance(0.5) };
+ gapLabelLine = { lineBetweenColumnTops.pointAtRelativeDistance(0.5), lineBetweenColumnBottoms.pointAtRelativeDistance(0.5) };
}
if (i < columnWidths.size() && i < columnPositions.size()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
