Title: [276278] trunk/Source/WebInspectorUI
- Revision
- 276278
- Author
- [email protected]
- Date
- 2021-04-19 17:18:01 -0700 (Mon, 19 Apr 2021)
Log Message
REGRESSION (r268691 && r270134): Web Inspector: Clicking on go-to arrow in Computed panel no longer works
https://bugs.webkit.org/show_bug.cgi?id=224774
Reviewed by Devin Rousso.
The Styles panel will not always be part of the same sidebar as the Computed panel as of r268691, so we should
look for the Styles panel in WI.detailsSidebar, which will report all of the panels it manages across multiple
sidebars. Additionally, as of r270134, there is no longer a private `_visible` property for
`WI.StyleDetailsPanel`, so it can not be used by `WI.SpreadsheetRulesStyleDetailsPanel`. Instead, visibility
should be determined by checking if the panel is attached and not pending layout.
* UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
(WI.ComputedStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
* UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
(WI.SpreadsheetRulesStyleDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (276277 => 276278)
--- trunk/Source/WebInspectorUI/ChangeLog 2021-04-19 23:37:20 UTC (rev 276277)
+++ trunk/Source/WebInspectorUI/ChangeLog 2021-04-20 00:18:01 UTC (rev 276278)
@@ -1,3 +1,21 @@
+2021-04-19 Patrick Angle <[email protected]>
+
+ REGRESSION (r268691 && r270134): Web Inspector: Clicking on go-to arrow in Computed panel no longer works
+ https://bugs.webkit.org/show_bug.cgi?id=224774
+
+ Reviewed by Devin Rousso.
+
+ The Styles panel will not always be part of the same sidebar as the Computed panel as of r268691, so we should
+ look for the Styles panel in WI.detailsSidebar, which will report all of the panels it manages across multiple
+ sidebars. Additionally, as of r270134, there is no longer a private `_visible` property for
+ `WI.StyleDetailsPanel`, so it can not be used by `WI.SpreadsheetRulesStyleDetailsPanel`. Instead, visibility
+ should be determined by checking if the panel is attached and not pending layout.
+
+ * UserInterface/Views/ComputedStyleDetailsSidebarPanel.js:
+ (WI.ComputedStyleDetailsSidebarPanel.prototype.computedStyleDetailsPanelShowProperty):
+ * UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js:
+ (WI.SpreadsheetRulesStyleDetailsPanel.prototype.scrollToSectionAndHighlightProperty):
+
2021-04-19 Devin Rousso <[email protected]>
Web Inspector: Graphics: add support for `steps()`/`spring()` CSS timing functions
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js (276277 => 276278)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js 2021-04-19 23:37:20 UTC (rev 276277)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ComputedStyleDetailsSidebarPanel.js 2021-04-20 00:18:01 UTC (rev 276278)
@@ -34,12 +34,12 @@
computedStyleDetailsPanelShowProperty(property)
{
- let styleRulesPanel = this.parentSidebar.sidebarPanels.find((panel) => panel instanceof WI.RulesStyleDetailsSidebarPanel);
+ let styleRulesPanel = WI.detailsSidebar.sidebarPanels.find((panel) => panel instanceof WI.RulesStyleDetailsSidebarPanel);
console.assert(styleRulesPanel, "Styles panel is missing.");
if (!styleRulesPanel)
return;
- this.parentSidebar.selectedSidebarPanel = styleRulesPanel;
+ WI.detailsSidebar.selectedSidebarPanel = styleRulesPanel;
styleRulesPanel.panel.scrollToSectionAndHighlightProperty(property);
}
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js (276277 => 276278)
--- trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2021-04-19 23:37:20 UTC (rev 276277)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/SpreadsheetRulesStyleDetailsPanel.js 2021-04-20 00:18:01 UTC (rev 276278)
@@ -68,7 +68,7 @@
scrollToSectionAndHighlightProperty(property)
{
- if (!this._visible) {
+ if (!this.isAttached || this.layoutPending) {
this._propertyToSelectAndHighlight = property;
return;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
