Title: [276288] trunk/Source/WebKit
- Revision
- 276288
- Author
- [email protected]
- Date
- 2021-04-20 00:12:26 -0700 (Tue, 20 Apr 2021)
Log Message
REGRESSION(r224516): Remote WebGL Context is not create due to RemoteRenderingBackend not being created
https://bugs.webkit.org/show_bug.cgi?id=224751
Patch by Kimmo Kinnunen <[email protected]> on 2021-04-20
Reviewed by Chris Dumez.
Fix WebGL GPU process after r275922.
RemoteRenderingBackend must be created so that RemoteGraphicsContextGL
can take a reference of it.
Fixes layout test failures when run with --gpu-process.
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
(WebKit::RemoteRenderingBackendProxy::ensureBackendCreated):
* WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createGraphicsContextGL const):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276287 => 276288)
--- trunk/Source/WebKit/ChangeLog 2021-04-20 06:33:49 UTC (rev 276287)
+++ trunk/Source/WebKit/ChangeLog 2021-04-20 07:12:26 UTC (rev 276288)
@@ -1,3 +1,23 @@
+2021-04-20 Kimmo Kinnunen <[email protected]>
+
+ REGRESSION(r224516): Remote WebGL Context is not create due to RemoteRenderingBackend not being created
+ https://bugs.webkit.org/show_bug.cgi?id=224751
+
+ Reviewed by Chris Dumez.
+
+ Fix WebGL GPU process after r275922.
+
+ RemoteRenderingBackend must be created so that RemoteGraphicsContextGL
+ can take a reference of it.
+
+ Fixes layout test failures when run with --gpu-process.
+
+ * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+ (WebKit::RemoteRenderingBackendProxy::ensureBackendCreated):
+ * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
+ * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+ (WebKit::WebChromeClient::createGraphicsContextGL const):
+
2021-04-19 Chris Dumez <[email protected]>
REGRESSION (r276189): GPUProcess.WebProcessTerminationAfterTooManyGPUProcessCrashes is crashing
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (276287 => 276288)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2021-04-20 06:33:49 UTC (rev 276287)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp 2021-04-20 07:12:26 UTC (rev 276288)
@@ -420,6 +420,12 @@
return m_parameters.identifier;
}
+RenderingBackendIdentifier RemoteRenderingBackendProxy::ensureBackendCreated()
+{
+ ensureGPUProcessConnection();
+ return renderingBackendIdentifier();
+}
+
} // namespace WebKit
#endif // ENABLE(GPU_PROCESS)
Modified: trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h (276287 => 276288)
--- trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h 2021-04-20 06:33:49 UTC (rev 276287)
+++ trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h 2021-04-20 07:12:26 UTC (rev 276288)
@@ -110,6 +110,8 @@
RenderingBackendIdentifier renderingBackendIdentifier() const;
+ RenderingBackendIdentifier ensureBackendCreated();
+
private:
explicit RemoteRenderingBackendProxy(WebPage&);
Modified: trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp (276287 => 276288)
--- trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp 2021-04-20 06:33:49 UTC (rev 276287)
+++ trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp 2021-04-20 07:12:26 UTC (rev 276288)
@@ -939,7 +939,7 @@
return nullptr;
UNUSED_VARIABLE(hostWindowDisplayID);
#if PLATFORM(COCOA) || PLATFORM(WIN)
- return RemoteGraphicsContextGLProxy::create(attributes, m_page.ensureRemoteRenderingBackendProxy().renderingBackendIdentifier());
+ return RemoteGraphicsContextGLProxy::create(attributes, m_page.ensureRemoteRenderingBackendProxy().ensureBackendCreated());
#else
return nullptr;
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
