Title: [276309] trunk/Source/WebKit
- Revision
- 276309
- Author
- [email protected]
- Date
- 2021-04-20 10:13:18 -0700 (Tue, 20 Apr 2021)
Log Message
[WPE] QML WPEView dynamic loading fails
https://bugs.webkit.org/show_bug.cgi?id=224814
Patch by Marco Felsch <[email protected]> on 2021-04-20
Reviewed by Philippe Normand.
The scene graph can be initialized when we receive window handle change
notification and so we will not receive a scenegraph initialization
notification. In such case we need to initzialize it ourself.
No new tests. Testing can be done if the WPEView is moved to a
QML component which gets loaded later on demand.
* UIProcess/API/wpe/qt/WPEQtView.cpp:
(WPEQtView::configureWindow):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276308 => 276309)
--- trunk/Source/WebKit/ChangeLog 2021-04-20 16:50:24 UTC (rev 276308)
+++ trunk/Source/WebKit/ChangeLog 2021-04-20 17:13:18 UTC (rev 276309)
@@ -1,5 +1,22 @@
2021-04-20 Marco Felsch <[email protected]>
+ [WPE] QML WPEView dynamic loading fails
+ https://bugs.webkit.org/show_bug.cgi?id=224814
+
+ Reviewed by Philippe Normand.
+
+ The scene graph can be initialized when we receive window handle change
+ notification and so we will not receive a scenegraph initialization
+ notification. In such case we need to initzialize it ourself.
+
+ No new tests. Testing can be done if the WPEView is moved to a
+ QML component which gets loaded later on demand.
+
+ * UIProcess/API/wpe/qt/WPEQtView.cpp:
+ (WPEQtView::configureWindow):
+
+2021-04-20 Marco Felsch <[email protected]>
+
[WPE][Qt] Fix build failure after r270690
https://bugs.webkit.org/show_bug.cgi?id=223070
Modified: trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp (276308 => 276309)
--- trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp 2021-04-20 16:50:24 UTC (rev 276308)
+++ trunk/Source/WebKit/UIProcess/API/wpe/qt/WPEQtView.cpp 2021-04-20 17:13:18 UTC (rev 276309)
@@ -79,7 +79,11 @@
return;
win->setSurfaceType(QWindow::OpenGLSurface);
- connect(win, &QQuickWindow::sceneGraphInitialized, this, &WPEQtView::createWebView);
+
+ if (win->isSceneGraphInitialized())
+ createWebView();
+ else
+ connect(win, &QQuickWindow::sceneGraphInitialized, this, &WPEQtView::createWebView);
}
void WPEQtView::createWebView()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
