Diff
Modified: trunk/Source/WTF/ChangeLog (276331 => 276332)
--- trunk/Source/WTF/ChangeLog 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WTF/ChangeLog 2021-04-21 00:08:15 UTC (rev 276332)
@@ -1,3 +1,13 @@
+2021-04-20 Michael Catanzaro <[email protected]>
+
+ Lots of spurious -Wnonnull warnings with GCC 11
+ https://bugs.webkit.org/show_bug.cgi?id=224452
+
+ Reviewed by Darin Adler.
+
+ * wtf/RefPtr.h:
+ (WTF::DefaultRefDerefTraits::derefIfNotNull):
+
2021-04-20 Keith Miller <[email protected]>
FullGCActivityCallback should use the percentage of pages uncompressed in RAM to determine deferral.
Modified: trunk/Source/WTF/wtf/Compiler.h (276331 => 276332)
--- trunk/Source/WTF/wtf/Compiler.h 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WTF/wtf/Compiler.h 2021-04-21 00:08:15 UTC (rev 276332)
@@ -502,3 +502,7 @@
#define IGNORE_NULL_CHECK_WARNINGS_BEGIN IGNORE_WARNINGS_BEGIN("nonnull")
#define IGNORE_NULL_CHECK_WARNINGS_END IGNORE_WARNINGS_END
+
+/* https://bugs.webkit.org/show_bug.cgi?id=224452 */
+#define IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN IGNORE_GCC_WARNINGS_BEGIN("nonnull")
+#define IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_END IGNORE_GCC_WARNINGS_END
Modified: trunk/Source/WTF/wtf/RefPtr.h (276331 => 276332)
--- trunk/Source/WTF/wtf/RefPtr.h 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WTF/wtf/RefPtr.h 2021-04-21 00:08:15 UTC (rev 276332)
@@ -38,8 +38,10 @@
static ALWAYS_INLINE void derefIfNotNull(T* ptr)
{
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN
if (LIKELY(ptr != nullptr))
ptr->deref();
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_END
}
};
Modified: trunk/Source/WebCore/ChangeLog (276331 => 276332)
--- trunk/Source/WebCore/ChangeLog 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WebCore/ChangeLog 2021-04-21 00:08:15 UTC (rev 276332)
@@ -1,3 +1,17 @@
+2021-04-20 Michael Catanzaro <[email protected]>
+
+ Lots of spurious -Wnonnull warnings with GCC 11
+ https://bugs.webkit.org/show_bug.cgi?id=224452
+
+ Reviewed by Darin Adler.
+
+ * css/CSSValue.h:
+ (WebCore::CSSValue::deref):
+ * css/StyleRule.h:
+ (WebCore::StyleRuleBase::deref const):
+ * dom/Node.h:
+ (WebCore::Node::deref const):
+
2021-04-20 Wenson Hsieh <[email protected]>
Rename WebCore::SelectionRect to WebCore::SelectionGeometry
Modified: trunk/Source/WebCore/css/CSSValue.h (276331 => 276332)
--- trunk/Source/WebCore/css/CSSValue.h 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WebCore/css/CSSValue.h 2021-04-21 00:08:15 UTC (rev 276332)
@@ -70,7 +70,9 @@
// the appropriate subclass type.
unsigned tempRefCount = m_refCount - refCountIncrement;
if (!tempRefCount) {
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN
destroy();
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_END
return;
}
m_refCount = tempRefCount;
Modified: trunk/Source/WebCore/css/StyleRule.h (276331 => 276332)
--- trunk/Source/WebCore/css/StyleRule.h 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WebCore/css/StyleRule.h 2021-04-21 00:08:15 UTC (rev 276332)
@@ -277,7 +277,9 @@
inline void StyleRuleBase::deref() const
{
if (derefBase())
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN
const_cast<StyleRuleBase&>(*this).destroy();
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_END
}
inline void StyleRule::wrapperAdoptSelectorList(CSSSelectorList&& selectors)
Modified: trunk/Source/WebCore/dom/Node.h (276331 => 276332)
--- trunk/Source/WebCore/dom/Node.h 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WebCore/dom/Node.h 2021-04-21 00:08:15 UTC (rev 276332)
@@ -794,7 +794,9 @@
#if ASSERT_ENABLED
m_inRemovedLastRefFunction = true;
#endif
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN
const_cast<Node&>(*this).removedLastRef();
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_END
return;
}
m_refCountAndParentBit = updatedRefCount;
Modified: trunk/Source/WebKit/ChangeLog (276331 => 276332)
--- trunk/Source/WebKit/ChangeLog 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WebKit/ChangeLog 2021-04-21 00:08:15 UTC (rev 276332)
@@ -1,3 +1,12 @@
+2021-04-20 Michael Catanzaro <[email protected]>
+
+ Lots of spurious -Wnonnull warnings with GCC 11
+ https://bugs.webkit.org/show_bug.cgi?id=224452
+
+ Reviewed by Darin Adler.
+
+ * WebProcess/Plugins/PluginView.cpp:
+
2021-04-20 Wenson Hsieh <[email protected]>
Rename WebCore::SelectionRect to WebCore::SelectionGeometry
Modified: trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp (276331 => 276332)
--- trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp 2021-04-21 00:03:56 UTC (rev 276331)
+++ trunk/Source/WebKit/WebProcess/Plugins/PluginView.cpp 2021-04-21 00:08:15 UTC (rev 276332)
@@ -145,6 +145,7 @@
RefPtr<NetscapePlugInStreamLoader> m_loader;
};
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_BEGIN
PluginView::Stream::~Stream()
{
if (m_loadCallback)
@@ -151,6 +152,7 @@
m_loadCallback({ });
ASSERT(!m_pluginView);
}
+IGNORE_ERRONEOUS_GCC_NULL_CHECK_WARNINGS_END
void PluginView::Stream::start()
{
