Diff
Modified: trunk/ChangeLog (276381 => 276382)
--- trunk/ChangeLog 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/ChangeLog 2021-04-21 19:08:46 UTC (rev 276382)
@@ -1,3 +1,18 @@
+2021-04-21 Martin Robinson <[email protected]>
+
+ Enable CSS Scroll Snap by default
+ https://bugs.webkit.org/show_bug.cgi?id=224867
+
+ Reviewed by Don Olmstead.
+
+ * Source/cmake/OptionsFTW.cmake: Remove redundant line enabling scroll snap.
+ * Source/cmake/OptionsGTK.cmake: Ditto.
+ * Source/cmake/OptionsMac.cmake: Ditto.
+ * Source/cmake/OptionsWPE.cmake: Ditto.
+ * Source/cmake/OptionsWin.cmake: Explicitly disable scroll snap for AppleWin port
+ until it can be approved by maintainers.
+ * Source/cmake/WebKitFeatures.cmake: Enable scroll snap by default.
+
2021-04-21 Don Olmstead <[email protected]>
[CMake] Add OpenGLES2 targets
Modified: trunk/Source/WTF/ChangeLog (276381 => 276382)
--- trunk/Source/WTF/ChangeLog 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/WTF/ChangeLog 2021-04-21 19:08:46 UTC (rev 276382)
@@ -1,3 +1,13 @@
+2021-04-21 Martin Robinson <[email protected]>
+
+ Enable CSS Scroll Snap by default
+ https://bugs.webkit.org/show_bug.cgi?id=224867
+
+ Reviewed by Don Olmstead.
+
+ * wtf/PlatformEnable.h: Move the preprocessor enabling of scroll snap here.
+ * wtf/PlatformEnableCocoa.h: Move it from here.
+
2021-04-21 Simon Fraser <[email protected]>
Enhance scrolling-related trace points
Modified: trunk/Source/WTF/wtf/PlatformEnable.h (276381 => 276382)
--- trunk/Source/WTF/wtf/PlatformEnable.h 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/WTF/wtf/PlatformEnable.h 2021-04-21 19:08:46 UTC (rev 276382)
@@ -221,6 +221,10 @@
#define ENABLE_CSS_CONIC_GRADIENTS 0
#endif
+#if !defined(ENABLE_CSS_SCROLL_SNAP)
+#define ENABLE_CSS_SCROLL_SNAP 1
+#endif
+
#if !defined(ENABLE_CSS_TRANSFORM_STYLE_OPTIMIZED_3D)
#define ENABLE_CSS_TRANSFORM_STYLE_OPTIMIZED_3D 0
#endif
Modified: trunk/Source/WTF/wtf/PlatformEnableCocoa.h (276381 => 276382)
--- trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/WTF/wtf/PlatformEnableCocoa.h 2021-04-21 19:08:46 UTC (rev 276382)
@@ -140,10 +140,6 @@
#define ENABLE_CSS_PAINTING_API 1
#endif
-#if !defined(ENABLE_CSS_SCROLL_SNAP)
-#define ENABLE_CSS_SCROLL_SNAP 1
-#endif
-
#if !defined(ENABLE_CSS_SELECTORS_LEVEL4)
#define ENABLE_CSS_SELECTORS_LEVEL4 1
#endif
Modified: trunk/Source/cmake/OptionsFTW.cmake (276381 => 276382)
--- trunk/Source/cmake/OptionsFTW.cmake 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/cmake/OptionsFTW.cmake 2021-04-21 19:08:46 UTC (rev 276382)
@@ -131,7 +131,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_ASYNC_SCROLLING PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_EXTENSIONS PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_FILTERING PRIVATE OFF)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DARK_MODE_CSS PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DATACUE_VALUE PRIVATE OFF)
Modified: trunk/Source/cmake/OptionsGTK.cmake (276381 => 276382)
--- trunk/Source/cmake/OptionsGTK.cmake 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/cmake/OptionsGTK.cmake 2021-04-21 19:08:46 UTC (rev 276382)
@@ -147,7 +147,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_EXTENSIONS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_CONIC_GRADIENTS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CURSOR_VISIBILITY PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_DARK_MODE_CSS PRIVATE ON)
Modified: trunk/Source/cmake/OptionsMac.cmake (276381 => 276382)
--- trunk/Source/cmake/OptionsMac.cmake 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/cmake/OptionsMac.cmake 2021-04-21 19:08:46 UTC (rev 276382)
@@ -30,7 +30,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_COMPOSITING PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_CONIC_GRADIENTS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ON)
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SELECTORS_LEVEL4 PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TRAILING_WORD PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ON)
Modified: trunk/Source/cmake/OptionsWPE.cmake (276381 => 276382)
--- trunk/Source/cmake/OptionsWPE.cmake 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/cmake/OptionsWPE.cmake 2021-04-21 19:08:46 UTC (rev 276382)
@@ -47,7 +47,6 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CONTENT_EXTENSIONS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_CONIC_GRADIENTS PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_PAINTING_API PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
-WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_TYPED_OM PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_FILTERS_LEVEL_2 PRIVATE ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_GPU_PROCESS PRIVATE OFF)
Modified: trunk/Source/cmake/OptionsWin.cmake (276381 => 276382)
--- trunk/Source/cmake/OptionsWin.cmake 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/cmake/OptionsWin.cmake 2021-04-21 19:08:46 UTC (rev 276382)
@@ -91,6 +91,7 @@
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_NETSCAPE_PLUGIN_API PRIVATE OFF)
else ()
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_COMPOSITING PUBLIC OFF)
+ WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_CSS_SCROLL_SNAP PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_LEGACY_ENCRYPTED_MEDIA PUBLIC ON)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_PUBLIC_SUFFIX_LIST PRIVATE OFF)
WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_REMOTE_INSPECTOR PRIVATE OFF)
Modified: trunk/Source/cmake/WebKitFeatures.cmake (276381 => 276382)
--- trunk/Source/cmake/WebKitFeatures.cmake 2021-04-21 19:07:56 UTC (rev 276381)
+++ trunk/Source/cmake/WebKitFeatures.cmake 2021-04-21 19:08:46 UTC (rev 276382)
@@ -149,7 +149,7 @@
WEBKIT_OPTION_DEFINE(ENABLE_CSS_DEVICE_ADAPTATION "Toggle CSS Device Adaptation support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_IMAGE_RESOLUTION "Toggle CSS image-resolution support" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_PAINTING_API "Toggle CSS Painting API support" PRIVATE OFF)
- WEBKIT_OPTION_DEFINE(ENABLE_CSS_SCROLL_SNAP "Toggle CSS snap scroll support" PRIVATE OFF)
+ WEBKIT_OPTION_DEFINE(ENABLE_CSS_SCROLL_SNAP "Toggle CSS snap scroll support" PRIVATE ON)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_SELECTORS_LEVEL4 "Toggle CSS Selectors Level 4 support" PRIVATE ON)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_TRAILING_WORD "Toggle css trailing word" PRIVATE OFF)
WEBKIT_OPTION_DEFINE(ENABLE_CSS_TYPED_OM "Toggle CSS Typed OM support" PRIVATE OFF)
