Title: [276413] trunk/Source/WebKit
- Revision
- 276413
- Author
- [email protected]
- Date
- 2021-04-21 18:15:13 -0700 (Wed, 21 Apr 2021)
Log Message
PCM: Remove PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable overrides in testing
https://bugs.webkit.org/show_bug.cgi?id=224885
<rdar://problem/76973184>
Reviewed by Brent Fulgham.
We had a temporary override to PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable
in WebKit::PrivateClickMeasurementManager::getTokenPublicKey() and
WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken().
This patch removes those overrides since the network load hang has been resolved.
No new tests. Existing tests cover this code.
* NetworkProcess/PrivateClickMeasurementManager.cpp:
(WebKit::PrivateClickMeasurementManager::getTokenPublicKey):
(WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276412 => 276413)
--- trunk/Source/WebKit/ChangeLog 2021-04-22 01:04:28 UTC (rev 276412)
+++ trunk/Source/WebKit/ChangeLog 2021-04-22 01:15:13 UTC (rev 276413)
@@ -1,3 +1,23 @@
+2021-04-21 John Wilander <[email protected]>
+
+ PCM: Remove PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable overrides in testing
+ https://bugs.webkit.org/show_bug.cgi?id=224885
+ <rdar://problem/76973184>
+
+ Reviewed by Brent Fulgham.
+
+ We had a temporary override to PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable
+ in WebKit::PrivateClickMeasurementManager::getTokenPublicKey() and
+ WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken().
+
+ This patch removes those overrides since the network load hang has been resolved.
+
+ No new tests. Existing tests cover this code.
+
+ * NetworkProcess/PrivateClickMeasurementManager.cpp:
+ (WebKit::PrivateClickMeasurementManager::getTokenPublicKey):
+ (WebKit::PrivateClickMeasurementManager::getSignedUnlinkableToken):
+
2021-04-21 Chris Dumez <[email protected]>
Regression(r275887) open.spotify.com says Safari is not supported
Modified: trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp (276412 => 276413)
--- trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp 2021-04-22 01:04:28 UTC (rev 276412)
+++ trunk/Source/WebKit/NetworkProcess/PrivateClickMeasurementManager.cpp 2021-04-22 01:15:13 UTC (rev 276413)
@@ -145,7 +145,6 @@
if (attributionReportEndpoint == PrivateClickMeasurement::AttributionReportEndpoint::Destination)
return;
tokenPublicKeyURL = *m_tokenPublicKeyURLForTesting;
- pcmDataCarried = PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable;
}
if (tokenPublicKeyURL.isEmpty() || !tokenPublicKeyURL.isValid())
@@ -183,10 +182,8 @@
// This is guaranteed to be close in time to the navigational click which makes it likely to be personally identifiable.
auto pcmDataCarried = PrivateClickMeasurement::PcmDataCarried::PersonallyIdentifiable;
auto tokenSignatureURL = attribution.tokenSignatureURL();
- if (m_tokenSignatureURLForTesting) {
+ if (m_tokenSignatureURLForTesting)
tokenSignatureURL = *m_tokenSignatureURLForTesting;
- pcmDataCarried = PrivateClickMeasurement::PcmDataCarried::NonPersonallyIdentifiable;
- }
if (tokenSignatureURL.isEmpty() || !tokenSignatureURL.isValid())
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
