Title: [276492] trunk/Source/WebCore
Revision
276492
Author
[email protected]
Date
2021-04-23 02:43:09 -0700 (Fri, 23 Apr 2021)

Log Message

Do not set synchronous scrolling for layers without relevant scrolling scopes
https://bugs.webkit.org/show_bug.cgi?id=221383

Reviewed by Simon Fraser.

Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
in RenderLayer::updateLayerPosition.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
setSynchronousScrollingReasons() if there is no scrollingScope.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (276491 => 276492)


--- trunk/Source/WebCore/ChangeLog	2021-04-23 09:23:04 UTC (rev 276491)
+++ trunk/Source/WebCore/ChangeLog	2021-04-23 09:43:09 UTC (rev 276492)
@@ -1,3 +1,18 @@
+2021-04-22  Sergio Villar Senin  <[email protected]>
+
+        Do not set synchronous scrolling for layers without relevant scrolling scopes
+        https://bugs.webkit.org/show_bug.cgi?id=221383
+
+        Reviewed by Simon Fraser.
+
+        Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
+        to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
+        in RenderLayer::updateLayerPosition.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
+        setSynchronousScrollingReasons() if there is no scrollingScope.
+
 2021-04-23  Philippe Normand  <[email protected]>
 
         [LibWebRTC][WPE][GTK] Enable vp9 and NO_MAIN_THREAD_WRAPPING

Modified: trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp (276491 => 276492)


--- trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2021-04-23 09:23:04 UTC (rev 276491)
+++ trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp	2021-04-23 09:43:09 UTC (rev 276492)
@@ -4948,8 +4948,7 @@
         if (!layer)
             continue;
 
-        auto scrollingScope = relevantScrollingScope(renderer, *layer);
-        if (scrollingScope != rootScrollingScope) {
+        if (auto scrollingScope = relevantScrollingScope(renderer, *layer); scrollingScope && scrollingScope != rootScrollingScope) {
             auto enclosingScrollingNodeID = asyncScrollableContainerNodeID(renderer);
             ASSERT(enclosingScrollingNodeID);
             
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to