Title: [276509] trunk/Source/WebKit
- Revision
- 276509
- Author
- [email protected]
- Date
- 2021-04-23 11:57:30 -0700 (Fri, 23 Apr 2021)
Log Message
Set proper network logging level for full web browsers
https://bugs.webkit.org/show_bug.cgi?id=224982
<rdar://problem/76903650>
Reviewed by Brent Fulgham.
Full web browsers have different low-level network logging requirements
for ephemeral sessions.
No new tests. There's no automated way to test if network level logs
show up. I tested that logging is correct for web browser and non web
browser apps manually.
* NetworkProcess/cocoa/NetworkSessionCocoa.mm:
(WebKit::configurationForSessionID):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276508 => 276509)
--- trunk/Source/WebKit/ChangeLog 2021-04-23 18:54:20 UTC (rev 276508)
+++ trunk/Source/WebKit/ChangeLog 2021-04-23 18:57:30 UTC (rev 276509)
@@ -1,3 +1,22 @@
+2021-04-23 Kate Cheney <[email protected]>
+
+ Set proper network logging level for full web browsers
+ https://bugs.webkit.org/show_bug.cgi?id=224982
+ <rdar://problem/76903650>
+
+ Reviewed by Brent Fulgham.
+
+ Full web browsers have different low-level network logging requirements
+ for ephemeral sessions.
+
+ No new tests. There's no automated way to test if network level logs
+ show up. I tested that logging is correct for web browser and non web
+ browser apps manually.
+
+ * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+ (WebKit::configurationForSessionID):
+ (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+
2021-04-23 Chris Dumez <[email protected]>
Disable GPUProcess on shipping iOS
Modified: trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm (276508 => 276509)
--- trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-04-23 18:54:20 UTC (rev 276508)
+++ trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm 2021-04-23 18:57:30 UTC (rev 276509)
@@ -1028,7 +1028,7 @@
static bool sessionsCreated = false;
#endif
-static NSURLSessionConfiguration *configurationForSessionID(const PAL::SessionID& session)
+static NSURLSessionConfiguration *configurationForSessionID(const PAL::SessionID& session, bool isFullWebBrowser)
{
#if HAVE(LOGGING_PRIVACY_LEVEL)
auto loggingPrivacyLevel = nw_context_privacy_level_sensitive;
@@ -1038,7 +1038,8 @@
if (session.isEphemeral()) {
configuration = [NSURLSessionConfiguration ephemeralSessionConfiguration];
#if HAVE(LOGGING_PRIVACY_LEVEL) && defined(NW_CONTEXT_HAS_PRIVACY_LEVEL_SILENT)
- loggingPrivacyLevel = nw_context_privacy_level_silent;
+ if (isFullWebBrowser)
+ loggingPrivacyLevel = nw_context_privacy_level_silent;
#endif
} else
configuration = [NSURLSessionConfiguration defaultSessionConfiguration];
@@ -1183,7 +1184,7 @@
sessionsCreated = true;
#endif
- NSURLSessionConfiguration *configuration = configurationForSessionID(m_sessionID);
+ NSURLSessionConfiguration *configuration = configurationForSessionID(m_sessionID, isParentProcessAFullWebBrowser(networkProcess));
#if HAVE(HSTS_STORAGE)
if (!!parameters.hstsStorageDirectory && !m_sessionID.isEphemeral()) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
