Title: [276515] trunk/Source/WebKit
- Revision
- 276515
- Author
- [email protected]
- Date
- 2021-04-23 13:11:39 -0700 (Fri, 23 Apr 2021)
Log Message
[iOS] GPU Process sandbox lacks IOMobileFramebufferUserClient method filter
https://bugs.webkit.org/show_bug.cgi?id=224956
<rdar://problem/68227590>
Reviewed by Per Arne Vollan.
This patch updates the GPU process sandbox to match the method filter used in the WebContent process
so that we will retain consistent protections when activating the GPU Process. These are the same rules
governing access to this resource when the GPU process is disabled, so should not create a change in behavior.
We also remove unneeded telemetry to reduce messaging burden and avoid performance issues.
* Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
* Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276514 => 276515)
--- trunk/Source/WebKit/ChangeLog 2021-04-23 19:53:26 UTC (rev 276514)
+++ trunk/Source/WebKit/ChangeLog 2021-04-23 20:11:39 UTC (rev 276515)
@@ -1,3 +1,20 @@
+2021-04-23 Brent Fulgham <[email protected]>
+
+ [iOS] GPU Process sandbox lacks IOMobileFramebufferUserClient method filter
+ https://bugs.webkit.org/show_bug.cgi?id=224956
+ <rdar://problem/68227590>
+
+ Reviewed by Per Arne Vollan.
+
+ This patch updates the GPU process sandbox to match the method filter used in the WebContent process
+ so that we will retain consistent protections when activating the GPU Process. These are the same rules
+ governing access to this resource when the GPU process is disabled, so should not create a change in behavior.
+
+ We also remove unneeded telemetry to reduce messaging burden and avoid performance issues.
+
+ * Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb:
+ * Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb:
+
2021-04-23 BJ Burg <[email protected]>
Web Inspector: [Cocoa] WKInspectorResourceURLSchemeHandler needs to serialize cleanup actions
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb (276514 => 276515)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb 2021-04-23 19:53:26 UTC (rev 276514)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.GPU.sb 2021-04-23 20:11:39 UTC (rev 276515)
@@ -87,7 +87,17 @@
(define-once (framebuffer-access)
(allow iokit-open
- (iokit-user-client-class "IOMobileFramebufferUserClient"))
+ (iokit-user-client-class "IOMobileFramebufferUserClient")
+ (when (defined? 'iokit-external-method)
+ (apply-message-filter
+ (deny (with telemetry)
+ iokit-async-external-method
+ iokit-external-trap)
+ (allow
+ iokit-external-method)
+ )
+ )
+ )
(mobile-preferences-read "com.apple.iokit.IOMobileGraphicsFamily"))
(define-once (asset-access . options)
Modified: trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb (276514 => 276515)
--- trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2021-04-23 19:53:26 UTC (rev 276514)
+++ trunk/Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb 2021-04-23 20:11:39 UTC (rev 276515)
@@ -96,7 +96,7 @@
(deny (with telemetry)
iokit-async-external-method
iokit-external-trap)
- (allow (with telemetry) (with message "IOMobileFramebufferUserClient")
+ (allow
iokit-external-method)
)
)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
