Title: [276568] trunk/Source/ThirdParty/ANGLE
Revision
276568
Author
[email protected]
Date
2021-04-25 12:16:23 -0700 (Sun, 25 Apr 2021)

Log Message

[Metal ANGLE] Temporarily remove AST validation even for debug builds
https://bugs.webkit.org/show_bug.cgi?id=224991
rdar://76299178

Patch by John Cunningham <[email protected]> on 2021-04-25
Reviewed by Kenneth Russell.

* src/libANGLE/renderer/metal/ShaderMtl.mm:
(rx::ShaderMtl::compileImplMtl):

Modified Paths

Diff

Modified: trunk/Source/ThirdParty/ANGLE/ChangeLog (276567 => 276568)


--- trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-04-25 19:06:07 UTC (rev 276567)
+++ trunk/Source/ThirdParty/ANGLE/ChangeLog	2021-04-25 19:16:23 UTC (rev 276568)
@@ -1,3 +1,14 @@
+2021-04-25  John Cunningham  <[email protected]>
+
+        [Metal ANGLE] Temporarily remove AST validation even for debug builds
+        https://bugs.webkit.org/show_bug.cgi?id=224991
+        rdar://76299178
+ 
+        Reviewed by Kenneth Russell.
+
+        * src/libANGLE/renderer/metal/ShaderMtl.mm:
+        (rx::ShaderMtl::compileImplMtl):
+
 2021-04-25  Kyle Piddington  <[email protected]>
 
         [Metal ANGLE] Select proper IOSurface backing format for WebGL environment

Modified: trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm (276567 => 276568)


--- trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm	2021-04-25 19:06:07 UTC (rev 276567)
+++ trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm	2021-04-25 19:16:23 UTC (rev 276568)
@@ -85,7 +85,9 @@
     const std::string &source,
     ShCompileOptions compileOptions)
 {
-#if defined(ANGLE_ENABLE_ASSERTS)
+// TODO(jcunningham): Remove this workaround once correct fix to move validation to the very end is in place.
+// See: https://bugs.webkit.org/show_bug.cgi?id=224991
+#if defined(ANGLE_ENABLE_ASSERTS) && 0
     compileOptions |= SH_VALIDATE_AST;
 #endif
 
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to