Title: [276647] trunk/LayoutTests
- Revision
- 276647
- Author
- [email protected]
- Date
- 2021-04-27 11:10:58 -0700 (Tue, 27 Apr 2021)
Log Message
fast/events/ios/dragstart-on-image-by-long-pressing.html sometimes fails with a text diff
https://bugs.webkit.org/show_bug.cgi?id=225107
rdar://77048635
Reviewed by Darin Adler.
For some reason, when running this layout test in a newly created simulator, the drag cancel preview animation
will finish animating *just* before the "dragend" event is dispatched, which causes the test to fail with a text
diff due to the missing `PASS Ended drag` output.
Address this by making the test robust in both cases (where the animation ends before the page receives
"dragend" and vice versa) by only finishing the test when we've met both conditions.
* fast/events/ios/dragstart-on-image-by-long-pressing-expected.txt:
* fast/events/ios/dragstart-on-image-by-long-pressing.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (276646 => 276647)
--- trunk/LayoutTests/ChangeLog 2021-04-27 17:40:34 UTC (rev 276646)
+++ trunk/LayoutTests/ChangeLog 2021-04-27 18:10:58 UTC (rev 276647)
@@ -1,3 +1,21 @@
+2021-04-27 Wenson Hsieh <[email protected]>
+
+ fast/events/ios/dragstart-on-image-by-long-pressing.html sometimes fails with a text diff
+ https://bugs.webkit.org/show_bug.cgi?id=225107
+ rdar://77048635
+
+ Reviewed by Darin Adler.
+
+ For some reason, when running this layout test in a newly created simulator, the drag cancel preview animation
+ will finish animating *just* before the "dragend" event is dispatched, which causes the test to fail with a text
+ diff due to the missing `PASS Ended drag` output.
+
+ Address this by making the test robust in both cases (where the animation ends before the page receives
+ "dragend" and vice versa) by only finishing the test when we've met both conditions.
+
+ * fast/events/ios/dragstart-on-image-by-long-pressing-expected.txt:
+ * fast/events/ios/dragstart-on-image-by-long-pressing.html:
+
2021-04-27 Zalan Bujtas <[email protected]>
[RenderTreeBuilder] ASSERTION FAILED: ancestor->style().columnSpan() != ColumnSpan::All || !isValidColumnSpanner(fragmentedFlow, *ancestor) in WebCore::isValidColumnSpanner
Modified: trunk/LayoutTests/fast/events/ios/dragstart-on-image-by-long-pressing-expected.txt (276646 => 276647)
--- trunk/LayoutTests/fast/events/ios/dragstart-on-image-by-long-pressing-expected.txt 2021-04-27 17:40:34 UTC (rev 276646)
+++ trunk/LayoutTests/fast/events/ios/dragstart-on-image-by-long-pressing-expected.txt 2021-04-27 18:10:58 UTC (rev 276647)
@@ -5,7 +5,7 @@
PASS Started drag
-PASS Ended drag
+PASS endedDrag became true
PASS successfullyParsed is true
TEST COMPLETE
Modified: trunk/LayoutTests/fast/events/ios/dragstart-on-image-by-long-pressing.html (276646 => 276647)
--- trunk/LayoutTests/fast/events/ios/dragstart-on-image-by-long-pressing.html 2021-04-27 17:40:34 UTC (rev 276646)
+++ trunk/LayoutTests/fast/events/ios/dragstart-on-image-by-long-pressing.html 2021-04-27 18:10:58 UTC (rev 276647)
@@ -20,8 +20,9 @@
testPassed("Started drag");
});
+ endedDrag = false;
image.addEventListener("dragend", () => {
- testPassed("Ended drag");
+ endedDrag = true;
});
if (!window.testRunner)
@@ -36,6 +37,7 @@
.end()
.takeResult());
+ await new Promise(resolve => shouldBecomeEqual("endedDrag", "true", resolve));
while (true) {
if (!await UIHelper.isAnimatingDragCancel())
break;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
