Title: [276652] trunk
Revision
276652
Author
[email protected]
Date
2021-04-27 11:52:48 -0700 (Tue, 27 Apr 2021)

Log Message

Unreviewed, reverting r275912.
rdar://77179042

Broke internal client

Reverted changeset:

"Remove support for NPAPI plugins in WebView"
https://bugs.webkit.org/show_bug.cgi?id=224449
https://commits.webkit.org/r275912

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (276651 => 276652)


--- trunk/Source/WTF/ChangeLog	2021-04-27 18:52:05 UTC (rev 276651)
+++ trunk/Source/WTF/ChangeLog	2021-04-27 18:52:48 UTC (rev 276652)
@@ -1,3 +1,16 @@
+2021-04-27  Alex Christensen  <[email protected]>
+
+        Unreviewed, reverting r275912.
+        rdar://77179042
+
+        Broke internal client
+
+        Reverted changeset:
+
+        "Remove support for NPAPI plugins in WebView"
+        https://bugs.webkit.org/show_bug.cgi?id=224449
+        https://commits.webkit.org/r275912
+
 2021-04-26  Ben Nham  <[email protected]>
 
         Reduce memory footprint for background tabs

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml (276651 => 276652)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2021-04-27 18:52:05 UTC (rev 276651)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml	2021-04-27 18:52:48 UTC (rev 276652)
@@ -1721,7 +1721,7 @@
   webcoreOnChange: pluginsEnabledChanged
   defaultValue:
     WebKitLegacy:
-      default: false
+      default: true
     WebKit:
       default: false
     WebCore:

Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (276651 => 276652)


--- trunk/Source/WebKitLegacy/mac/ChangeLog	2021-04-27 18:52:05 UTC (rev 276651)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog	2021-04-27 18:52:48 UTC (rev 276652)
@@ -1,3 +1,16 @@
+2021-04-27  Alex Christensen  <[email protected]>
+
+        Unreviewed, reverting r275912.
+        rdar://77179042
+
+        Broke internal client
+
+        Reverted changeset:
+
+        "Remove support for NPAPI plugins in WebView"
+        https://bugs.webkit.org/show_bug.cgi?id=224449
+        https://commits.webkit.org/r275912
+
 2021-04-23  Chris Dumez  <[email protected]>
 
         Improve our constructDeletedValue() template specializations

Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (276651 => 276652)


--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2021-04-27 18:52:05 UTC (rev 276651)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm	2021-04-27 18:52:48 UTC (rev 276652)
@@ -900,8 +900,7 @@
 
 - (void)setPlugInsEnabled:(BOOL)flag
 {
-    if (flag)
-        RELEASE_LOG_FAULT(Plugins, "Application attempted to enable WebView NPAPI plug ins, which are no longer supported");
+    [self _setBoolValue: flag forKey: WebKitPluginsEnabledPreferenceKey];
 }
 
 - (BOOL)allowsAnimatedImages

Modified: trunk/Tools/ChangeLog (276651 => 276652)


--- trunk/Tools/ChangeLog	2021-04-27 18:52:05 UTC (rev 276651)
+++ trunk/Tools/ChangeLog	2021-04-27 18:52:48 UTC (rev 276652)
@@ -1,3 +1,16 @@
+2021-04-27  Alex Christensen  <[email protected]>
+
+        Unreviewed, reverting r275912.
+        rdar://77179042
+
+        Broke internal client
+
+        Reverted changeset:
+
+        "Remove support for NPAPI plugins in WebView"
+        https://bugs.webkit.org/show_bug.cgi?id=224449
+        https://commits.webkit.org/r275912
+
 2021-04-27  Angelos Oikonomopoulos  <[email protected]>
 
         [JSC] Autoscale jobs for remote boards

Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (276651 => 276652)


--- trunk/Tools/DumpRenderTree/TestOptions.cpp	2021-04-27 18:52:05 UTC (rev 276651)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp	2021-04-27 18:52:48 UTC (rev 276652)
@@ -63,7 +63,6 @@
     static TestFeatures features;
     if (features.boolWebPreferenceFeatures.empty()) {
         features.boolWebPreferenceFeatures = {
-            { "PluginsEnabled", true },
 #if PLATFORM(COCOA)
             // These are non-experimental WebPreference values that must always be set as they
             // differ from the default set in the WebPreferences*.yaml configuration.
@@ -157,6 +156,7 @@
             { "ModernMediaControlsEnabled", true },
             { "NeedsStorageAccessFromFileURLsQuirk", false },
             { "OverscrollBehaviorEnabled", true },
+            { "PluginsEnabled", true },
             { "PrivateClickMeasurementEnabled", false },
             { "RequestIdleCallbackEnabled", false },
             { "ResizeObserverEnabled", false },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to