Title: [276671] trunk/Source/WebKit
- Revision
- 276671
- Author
- [email protected]
- Date
- 2021-04-27 15:11:16 -0700 (Tue, 27 Apr 2021)
Log Message
HashTableConstIterator's consistency assertion fails while closing m_webIDBServers in NetworkProcess::didClose since r275846
https://bugs.webkit.org/show_bug.cgi?id=225089
Reviewed by Chris Dumez.
The items of m_webIDBServers were removed while iterating
m_webIDBServers.
Move m_webIDBServers to a temporary HashMap before iterating.
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::didClose):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276670 => 276671)
--- trunk/Source/WebKit/ChangeLog 2021-04-27 22:09:45 UTC (rev 276670)
+++ trunk/Source/WebKit/ChangeLog 2021-04-27 22:11:16 UTC (rev 276671)
@@ -1,3 +1,18 @@
+2021-04-27 Fujii Hironori <[email protected]>
+
+ HashTableConstIterator's consistency assertion fails while closing m_webIDBServers in NetworkProcess::didClose since r275846
+ https://bugs.webkit.org/show_bug.cgi?id=225089
+
+ Reviewed by Chris Dumez.
+
+ The items of m_webIDBServers were removed while iterating
+ m_webIDBServers.
+
+ Move m_webIDBServers to a temporary HashMap before iterating.
+
+ * NetworkProcess/NetworkProcess.cpp:
+ (WebKit::NetworkProcess::didClose):
+
2021-04-27 Chris Dumez <[email protected]>
Copy-on-write semantics should be an internal implementation detail of StorageMap
Modified: trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp (276670 => 276671)
--- trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-04-27 22:09:45 UTC (rev 276670)
+++ trunk/Source/WebKit/NetworkProcess/NetworkProcess.cpp 2021-04-27 22:11:16 UTC (rev 276671)
@@ -274,7 +274,8 @@
});
// Make sure references to NetworkProcess in spaceRequester and closeHandler is removed.
- for (auto& server : m_webIDBServers.values())
+ auto servers = std::exchange(m_webIDBServers, { });
+ for (auto& server : servers.values())
server->close();
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
