Title: [276692] trunk/Source
Revision
276692
Author
[email protected]
Date
2021-04-27 23:39:41 -0700 (Tue, 27 Apr 2021)

Log Message

[PlayStation] Suppress warnings for %llu format specifier for uint64_t.
https://bugs.webkit.org/show_bug.cgi?id=225138

Reviewed by Darin Adler.

PRIu64 from <cstdint> should be use to format uint64_t value in printf.

Source/WebCore:

No new tests because there's no behavior change.

* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::startTermination):

Source/WebKit:

* NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::createFetchTask):
(WebKit::WebSWServerConnection::startFetch):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (276691 => 276692)


--- trunk/Source/WebCore/ChangeLog	2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebCore/ChangeLog	2021-04-28 06:39:41 UTC (rev 276692)
@@ -1,3 +1,17 @@
+2021-04-27  Basuke Suzuki  <[email protected]>
+
+        [PlayStation] Suppress warnings for %llu format specifier for uint64_t.
+        https://bugs.webkit.org/show_bug.cgi?id=225138
+
+        Reviewed by Darin Adler.
+
+        PRIu64 from <cstdint> should be use to format uint64_t value in printf.
+
+        No new tests because there's no behavior change.
+
+        * workers/service/server/SWServerWorker.cpp:
+        (WebCore::SWServerWorker::startTermination):
+
 2021-04-27  Chris Dumez  <[email protected]>
 
         Improve local storage size estimation for quota limitation

Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp (276691 => 276692)


--- trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp	2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.cpp	2021-04-28 06:39:41 UTC (rev 276692)
@@ -32,6 +32,7 @@
 #include "SWServer.h"
 #include "SWServerRegistration.h"
 #include "SWServerToContextConnection.h"
+#include <cstdint>
 #include <wtf/CompletionHandler.h>
 #include <wtf/NeverDestroyed.h>
 
@@ -116,7 +117,7 @@
     auto* contextConnection = this->contextConnection();
     ASSERT(contextConnection);
     if (!contextConnection) {
-        RELEASE_LOG_ERROR(ServiceWorker, "Request to terminate a worker %llu whose context connection does not exist", identifier().toUInt64());
+        RELEASE_LOG_ERROR(ServiceWorker, "Request to terminate a worker %" PRIu64 " whose context connection does not exist", identifier().toUInt64());
         setState(State::NotRunning);
         callback();
         m_server->workerContextTerminated(*this);

Modified: trunk/Source/WebKit/ChangeLog (276691 => 276692)


--- trunk/Source/WebKit/ChangeLog	2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebKit/ChangeLog	2021-04-28 06:39:41 UTC (rev 276692)
@@ -1,3 +1,16 @@
+2021-04-27  Basuke Suzuki  <[email protected]>
+
+        [PlayStation] Suppress warnings for %llu format specifier for uint64_t.
+        https://bugs.webkit.org/show_bug.cgi?id=225138
+
+        Reviewed by Darin Adler.
+
+        PRIu64 from <cstdint> should be use to format uint64_t value in printf.
+
+        * NetworkProcess/ServiceWorker/WebSWServerConnection.cpp:
+        (WebKit::WebSWServerConnection::createFetchTask):
+        (WebKit::WebSWServerConnection::startFetch):
+
 2021-04-27  Kimmo Kinnunen  <[email protected]>
 
         Add a Condition type that supports thread safety analysis

Modified: trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp (276691 => 276692)


--- trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	2021-04-28 06:26:12 UTC (rev 276691)
+++ trunk/Source/WebKit/NetworkProcess/ServiceWorker/WebSWServerConnection.cpp	2021-04-28 06:39:41 UTC (rev 276692)
@@ -54,6 +54,7 @@
 #include <WebCore/ServiceWorkerContextData.h>
 #include <WebCore/ServiceWorkerJobData.h>
 #include <WebCore/ServiceWorkerUpdateViaCache.h>
+#include <cstdint>
 #include <wtf/Algorithms.h>
 #include <wtf/MainThread.h>
 
@@ -179,7 +180,7 @@
 
     auto* worker = server().activeWorkerFromRegistrationID(*serviceWorkerRegistrationIdentifier);
     if (!worker) {
-        SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because no active worker for registration %llu", serviceWorkerRegistrationIdentifier->toUInt64());
+        SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because no active worker for registration %" PRIu64, serviceWorkerRegistrationIdentifier->toUInt64());
         return nullptr;
     }
 
@@ -193,7 +194,7 @@
     }
 
     if (worker->hasTimedOutAnyFetchTasks()) {
-        SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because worker %llu has some timeouts", worker->identifier().toUInt64());
+        SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: DidNotHandle because worker %" PRIu64 " has some timeouts", worker->identifier().toUInt64());
         return nullptr;
     }
 
@@ -214,7 +215,7 @@
         }
 
         if (!success) {
-            SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: fetchIdentifier=%llu DidNotHandle because worker did not become activated", task->fetchIdentifier().toUInt64());
+            SWSERVERCONNECTION_RELEASE_LOG_ERROR_IF_ALLOWED("startFetch: fetchIdentifier=%" PRIu64 " DidNotHandle because worker did not become activated", task->fetchIdentifier().toUInt64());
             task->cannotHandle();
             return;
         }
@@ -243,7 +244,7 @@
                 task->cannotHandle();
                 return;
             }
-            SWSERVERCONNECTION_RELEASE_LOG_IF_ALLOWED("startFetch: Starting fetch %llu via service worker %llu", task->fetchIdentifier().toUInt64(), task->serviceWorkerIdentifier().toUInt64());
+            SWSERVERCONNECTION_RELEASE_LOG_IF_ALLOWED("startFetch: Starting fetch %" PRIu64 " via service worker %" PRIu64, task->fetchIdentifier().toUInt64(), task->serviceWorkerIdentifier().toUInt64());
             static_cast<WebSWServerToContextConnection&>(*contextConnection).startFetch(*task);
         });
     };
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to