Diff
Modified: trunk/Source/WTF/ChangeLog (276714 => 276715)
--- trunk/Source/WTF/ChangeLog 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WTF/ChangeLog 2021-04-28 15:44:02 UTC (rev 276715)
@@ -1,3 +1,17 @@
+2021-04-28 Chris Dumez <[email protected]>
+
+ Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=225130
+
+ Reviewed by Eric Carlson.
+
+ Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags now that
+ these features have shipped. It also doesn't make sense to disable them given
+ that the prefixed WebAudio API is no longer exposed and there is no feature flag
+ to turn the legacy prefixed API back on.
+
+ * Scripts/Preferences/WebPreferencesExperimental.yaml:
+
2021-04-28 Kimmo Kinnunen <[email protected]>
Asserting that function or variable is accessed in a certain thread should be simpler and more robust
Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (276714 => 276715)
--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml 2021-04-28 15:44:02 UTC (rev 276715)
@@ -75,20 +75,6 @@
WebCore:
default: false
-AudioWorkletEnabled:
- type: bool
- humanReadableName: "WebAudio AudioWorklet API"
- humanReadableDescription: "WebAudio AudioWorklet API"
- condition: ENABLE(WEB_AUDIO)
- defaultValue:
- WebKitLegacy:
- "PLATFORM(IOS_FAMILY)" : true
- default: false
- WebKit:
- default: true
- WebCore:
- default: false
-
BlankAnchorTargetImpliesNoOpenerEnabled:
type: bool
humanReadableName: "Blank anchor target implies rel=noopener"
@@ -709,20 +695,6 @@
WebCore:
default: false
-ModernUnprefixedWebAudioEnabled:
- type: bool
- humanReadableName: "Modern WebAudio API"
- humanReadableDescription: "Modern and unprefixed WebAudio API"
- condition: ENABLE(WEB_AUDIO)
- defaultValue:
- WebKitLegacy:
- "PLATFORM(IOS_FAMILY)" : true
- default: false
- WebKit:
- default: true
- WebCore:
- default: false
-
OpusDecoderEnabled:
type: bool
humanReadableName: "Opus audio decoder"
Modified: trunk/Source/WebCore/ChangeLog (276714 => 276715)
--- trunk/Source/WebCore/ChangeLog 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/ChangeLog 2021-04-28 15:44:02 UTC (rev 276715)
@@ -1,3 +1,45 @@
+2021-04-28 Chris Dumez <[email protected]>
+
+ Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=225130
+
+ Reviewed by Eric Carlson.
+
+ Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags now that
+ these features have shipped. It also doesn't make sense to disable them given
+ that the prefixed WebAudio API is no longer exposed and there is no feature flag
+ to turn the legacy prefixed API back on.
+
+ * Modules/webaudio/AnalyserNode.idl:
+ * Modules/webaudio/AudioBuffer.idl:
+ * Modules/webaudio/AudioBufferSourceNode.idl:
+ * Modules/webaudio/AudioContext.idl:
+ * Modules/webaudio/AudioParamMap.idl:
+ * Modules/webaudio/AudioProcessingEvent.idl:
+ * Modules/webaudio/AudioWorklet.idl:
+ * Modules/webaudio/AudioWorkletNode.idl:
+ * Modules/webaudio/AudioWorkletNodeOptions.idl:
+ * Modules/webaudio/BaseAudioContext.idl:
+ * Modules/webaudio/BiquadFilterNode.idl:
+ * Modules/webaudio/ChannelMergerNode.idl:
+ * Modules/webaudio/ChannelSplitterNode.idl:
+ * Modules/webaudio/ConstantSourceNode.idl:
+ * Modules/webaudio/ConstantSourceOptions.idl:
+ * Modules/webaudio/ConvolverNode.idl:
+ * Modules/webaudio/DelayNode.idl:
+ * Modules/webaudio/DynamicsCompressorNode.idl:
+ * Modules/webaudio/GainNode.idl:
+ * Modules/webaudio/IIRFilterNode.idl:
+ * Modules/webaudio/MediaElementAudioSourceNode.idl:
+ * Modules/webaudio/MediaStreamAudioDestinationNode.idl:
+ * Modules/webaudio/MediaStreamAudioSourceNode.idl:
+ * Modules/webaudio/OfflineAudioContext.idl:
+ * Modules/webaudio/OscillatorNode.idl:
+ * Modules/webaudio/PannerNode.idl:
+ * Modules/webaudio/PeriodicWave.idl:
+ * Modules/webaudio/StereoPannerNode.idl:
+ * Modules/webaudio/WaveShaperNode.idl:
+
2021-04-28 Zalan Bujtas <[email protected]>
Remove unused RenderObject::isOutOfFlowRenderFragmentedFlow
Modified: trunk/Source/WebCore/Modules/webaudio/AnalyserNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AnalyserNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AnalyserNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,7 +27,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface AnalyserNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional AnalyserOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional AnalyserOptions options);
attribute unsigned long fftSize;
readonly attribute unsigned long frequencyBinCount;
@@ -45,6 +45,6 @@
undefined getByteFrequencyData(Uint8Array array);
// Real-time waveform data
- [EnabledBySetting=ModernUnprefixedWebAudio] undefined getFloatTimeDomainData(Float32Array array);
+ undefined getFloatTimeDomainData(Float32Array array);
undefined getByteTimeDomainData(Uint8Array array);
};
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBuffer.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioBuffer.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBuffer.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -34,7 +34,7 @@
ReportExtraMemoryCost,
Exposed=Window
] interface AudioBuffer {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor(AudioBufferOptions options);
+ [EnabledBySetting=WebAudio] constructor(AudioBufferOptions options);
[ImplementedAs=originalLength] readonly attribute unsigned long length; // in sample-frames
[ImplementedAs=originalDuration] readonly attribute double duration; // in seconds
readonly attribute float sampleRate; // in sample-frames per second
@@ -42,6 +42,6 @@
// Channel access
[CallWith=GlobalObject] any getChannelData(unsigned long channelIndex);
- [EnabledBySetting=ModernUnprefixedWebAudio] undefined copyFromChannel(Float32Array destination, unsigned long channelNumber, optional unsigned long bufferOffset = 0);
- [EnabledBySetting=ModernUnprefixedWebAudio] undefined copyToChannel(Float32Array source, unsigned long channelNumber, optional unsigned long bufferOffset = 0);
+ undefined copyFromChannel(Float32Array destination, unsigned long channelNumber, optional unsigned long bufferOffset = 0);
+ undefined copyToChannel(Float32Array source, unsigned long channelNumber, optional unsigned long bufferOffset = 0);
};
Modified: trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioBufferSourceNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -29,7 +29,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface AudioBufferSourceNode : AudioScheduledSourceNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional AudioBufferSourceOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional AudioBufferSourceOptions options);
attribute AudioBuffer? buffer;
Modified: trunk/Source/WebCore/Modules/webaudio/AudioContext.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioContext.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioContext.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -26,7 +26,7 @@
[
ActiveDOMObject,
Conditional=WEB_AUDIO,
- EnabledBySetting=WebAudio&ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio,
ExportMacro=WEBCORE_EXPORT,
JSGenerateToNativeObject,
Exposed=Window
Modified: trunk/Source/WebCore/Modules/webaudio/AudioParamMap.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioParamMap.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioParamMap.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -28,7 +28,7 @@
[
Conditional=WEB_AUDIO,
- EnabledBySetting=AudioWorklet,
+ EnabledBySetting=WebAudio,
SkipVTableValidation,
Exposed=Window
] interface AudioParamMap {
Modified: trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioProcessingEvent.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,7 +27,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface AudioProcessingEvent : Event {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (DOMString type, AudioProcessingEventInit eventInitDict);
+ [EnabledBySetting=WebAudio] constructor (DOMString type, AudioProcessingEventInit eventInitDict);
readonly attribute double playbackTime;
readonly attribute AudioBuffer inputBuffer;
readonly attribute AudioBuffer outputBuffer;
Modified: trunk/Source/WebCore/Modules/webaudio/AudioWorklet.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioWorklet.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioWorklet.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -28,7 +28,7 @@
[
Conditional=WEB_AUDIO,
- EnabledBySetting=AudioWorklet,
+ EnabledBySetting=WebAudio,
Exposed=Window,
JSGenerateToJSObject,
SecureContext
Modified: trunk/Source/WebCore/Modules/webaudio/AudioWorkletNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioWorkletNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioWorkletNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -29,7 +29,7 @@
[
ActiveDOMObject,
Conditional=WEB_AUDIO,
- EnabledBySetting=AudioWorklet,
+ EnabledBySetting=WebAudio,
Exposed=Window,
JSGenerateToJSObject,
SecureContext
Modified: trunk/Source/WebCore/Modules/webaudio/AudioWorkletNodeOptions.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/AudioWorkletNodeOptions.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/AudioWorkletNodeOptions.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -28,7 +28,7 @@
[
Conditional=WEB_AUDIO,
- EnabledBySetting=AudioWorklet,
+ EnabledBySetting=WebAudio,
JSGenerateToJSObject
] dictionary AudioWorkletNodeOptions : AudioNodeOptions {
unsigned long numberOfInputs = 1;
Modified: trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/BaseAudioContext.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,7 +27,7 @@
ActiveDOMObject,
Conditional=WEB_AUDIO,
CustomToJSObject,
- EnabledBySetting=WebAudio&ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio,
ExportMacro=WEBCORE_EXPORT,
Exposed=Window
] interface BaseAudioContext : EventTarget {
@@ -43,7 +43,7 @@
// All panning is relative to this listener.
readonly attribute AudioListener listener;
- [SameObject, SecureContext, EnabledBySetting=AudioWorklet] readonly attribute AudioWorklet audioWorklet;
+ [SameObject, SecureContext] readonly attribute AudioWorklet audioWorklet;
readonly attribute AudioContextState state;
attribute EventHandler onstatechange;
Modified: trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/BiquadFilterNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -28,7 +28,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface BiquadFilterNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional BiquadFilterOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional BiquadFilterOptions options);
attribute BiquadFilterType type;
Modified: trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelMergerNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -31,5 +31,5 @@
JSGenerateToJSObject,
Exposed=Window
] interface ChannelMergerNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional ChannelMergerOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional ChannelMergerOptions options);
};
Modified: trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/ChannelSplitterNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,5 +27,5 @@
JSGenerateToJSObject,
Exposed=Window
] interface ChannelSplitterNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional ChannelSplitterOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional ChannelSplitterOptions options);
};
Modified: trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/ConstantSourceNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -26,7 +26,7 @@
[
Conditional=WEB_AUDIO,
JSGenerateToJSObject,
- EnabledBySetting=ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio,
Exposed=Window
] interface ConstantSourceNode : AudioScheduledSourceNode {
constructor (BaseAudioContext context, optional ConstantSourceOptions options);
Modified: trunk/Source/WebCore/Modules/webaudio/ConstantSourceOptions.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/ConstantSourceOptions.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/ConstantSourceOptions.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -25,7 +25,7 @@
[
Conditional=WEB_AUDIO,
- EnabledBySetting=ModernUnprefixedWebAudio
+ EnabledBySetting=WebAudio
] dictionary ConstantSourceOptions {
float offset = 1;
};
Modified: trunk/Source/WebCore/Modules/webaudio/ConvolverNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/ConvolverNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/ConvolverNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -29,7 +29,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface ConvolverNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional ConvolverOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional ConvolverOptions options);
attribute AudioBuffer? buffer;
attribute boolean normalize;
Modified: trunk/Source/WebCore/Modules/webaudio/DelayNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/DelayNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/DelayNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,7 +27,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface DelayNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional DelayOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional DelayOptions options);
readonly attribute AudioParam delayTime;
};
Modified: trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/DynamicsCompressorNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -28,7 +28,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface DynamicsCompressorNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional DynamicsCompressorOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional DynamicsCompressorOptions options);
readonly attribute AudioParam threshold; // in Decibels
readonly attribute AudioParam knee; // in Decibels
Modified: trunk/Source/WebCore/Modules/webaudio/GainNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/GainNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/GainNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,7 +27,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface GainNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional GainOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional GainOptions options);
readonly attribute AudioParam gain;
};
Modified: trunk/Source/WebCore/Modules/webaudio/IIRFilterNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/IIRFilterNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/IIRFilterNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -25,7 +25,7 @@
[
Conditional=WEB_AUDIO,
JSGenerateToJSObject,
- EnabledBySetting=ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio,
Exposed=Window
] interface IIRFilterNode : AudioNode {
[CallWith=ScriptExecutionContext] constructor(BaseAudioContext audioContext, IIRFilterOptions options);
Modified: trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -28,7 +28,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface MediaElementAudioSourceNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (AudioContext context, MediaElementAudioSourceOptions options);
+ [EnabledBySetting=WebAudio] constructor (AudioContext context, MediaElementAudioSourceOptions options);
readonly attribute HTMLMediaElement mediaElement;
};
Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioDestinationNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,6 +27,6 @@
JSGenerateToJSObject,
Exposed=Window
] interface MediaStreamAudioDestinationNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (AudioContext context, optional AudioNodeOptions options);
+ [EnabledBySetting=WebAudio] constructor (AudioContext context, optional AudioNodeOptions options);
readonly attribute MediaStream stream;
};
Modified: trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,7 +27,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface MediaStreamAudioSourceNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (AudioContext context, MediaStreamAudioSourceOptions options);
+ [EnabledBySetting=WebAudio] constructor (AudioContext context, MediaStreamAudioSourceOptions options);
readonly attribute MediaStream mediaStream;
};
Modified: trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/OfflineAudioContext.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -24,7 +24,7 @@
[
Conditional=WEB_AUDIO,
- EnabledBySetting=ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio,
JSGenerateToJSObject,
Exposed=Window
] interface OfflineAudioContext : BaseAudioContext {
Modified: trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/OscillatorNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -29,7 +29,7 @@
ActiveDOMObject,
Exposed=Window
] interface OscillatorNode : AudioScheduledSourceNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor (BaseAudioContext context, optional OscillatorOptions options);
+ [EnabledBySetting=WebAudio] constructor (BaseAudioContext context, optional OscillatorOptions options);
attribute OscillatorType type;
Modified: trunk/Source/WebCore/Modules/webaudio/PannerNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/PannerNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/PannerNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -25,7 +25,7 @@
[
Conditional=WEB_AUDIO,
JSGenerateToJSObject,
- EnabledBySetting=ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio,
Exposed=Window
] interface PannerNode : AudioNode {
constructor (BaseAudioContext context, optional PannerOptions options);
Modified: trunk/Source/WebCore/Modules/webaudio/PeriodicWave.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/PeriodicWave.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/PeriodicWave.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -28,5 +28,5 @@
ImplementationLacksVTable,
Exposed=Window
] interface PeriodicWave {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor(BaseAudioContext context, optional PeriodicWaveOptions options);
+ [EnabledBySetting=WebAudio] constructor(BaseAudioContext context, optional PeriodicWaveOptions options);
};
Modified: trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/StereoPannerNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -26,7 +26,7 @@
[
Conditional=WEB_AUDIO,
JSGenerateToJSObject,
- EnabledBySetting=ModernUnprefixedWebAudio,
+ EnabledBySetting=WebAudio,
Exposed=Window
] interface StereoPannerNode : AudioNode {
constructor (BaseAudioContext context, optional StereoPannerOptions options);
Modified: trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.idl (276714 => 276715)
--- trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.idl 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebCore/Modules/webaudio/WaveShaperNode.idl 2021-04-28 15:44:02 UTC (rev 276715)
@@ -27,7 +27,7 @@
JSGenerateToJSObject,
Exposed=Window
] interface WaveShaperNode : AudioNode {
- [EnabledBySetting=ModernUnprefixedWebAudio] constructor(BaseAudioContext context, optional WaveShaperOptions options);
+ [EnabledBySetting=WebAudio] constructor(BaseAudioContext context, optional WaveShaperOptions options);
attribute Float32Array? curve;
attribute OverSampleType oversample;
Modified: trunk/Source/WebKitLegacy/mac/ChangeLog (276714 => 276715)
--- trunk/Source/WebKitLegacy/mac/ChangeLog 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebKitLegacy/mac/ChangeLog 2021-04-28 15:44:02 UTC (rev 276715)
@@ -1,3 +1,23 @@
+2021-04-28 Chris Dumez <[email protected]>
+
+ Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags
+ https://bugs.webkit.org/show_bug.cgi?id=225130
+
+ Reviewed by Eric Carlson.
+
+ Drop ModernUnprefixedWebAudio & AudioWorklet experimental feature flags now that
+ these features have shipped. It also doesn't make sense to disable them given
+ that the prefixed WebAudio API is no longer exposed and there is no feature flag
+ to turn the legacy prefixed API back on.
+
+ * WebView/WebPreferenceKeysPrivate.h:
+ * WebView/WebPreferences.mm:
+ (-[WebPreferences modernUnprefixedWebAudioEnabled]): Deleted.
+ (-[WebPreferences setModernUnprefixedWebAudioEnabled:]): Deleted.
+ (-[WebPreferences audioWorkletEnabled]): Deleted.
+ (-[WebPreferences setAudioWorkletEnabled:]): Deleted.
+ * WebView/WebPreferencesPrivate.h:
+
2021-04-27 Alex Christensen <[email protected]>
charset in contentType used in Blob.prototype.slice(start, end, contentType) is lost
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h (276714 => 276715)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h 2021-04-28 15:44:02 UTC (rev 276715)
@@ -252,8 +252,6 @@
// These are all now generated via GeneratePreferences.rb
// FIXME: If these are not used anywhere, we should remove them and only use WebFeature mechanism for the preference.
#define WebKitUserGesturePromisePropagationEnabledPreferenceKey @"WebKitUserGesturePromisePropagationEnabled"
-#define WebKitModernUnprefixedWebAudioEnabledPreferenceKey @"WebKitModernUnprefixedWebAudioEnabled"
-#define WebKitAudioWorkletEnabledPreferenceKey @"WebKitAudioWorkletEnabled"
#define WebKitRequestIdleCallbackEnabledPreferenceKey @"WebKitRequestIdleCallbackEnabled"
#define WebKitHighlightAPIEnabledPreferenceKey @"WebKitHighlightAPIEnabled"
#define WebKitAsyncClipboardAPIEnabledPreferenceKey @"WebKitAsyncClipboardAPIEnabled"
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm (276714 => 276715)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm 2021-04-28 15:44:02 UTC (rev 276715)
@@ -3075,26 +3075,6 @@
[self _setBoolValue:flag forKey:WebKitUserGesturePromisePropagationEnabledPreferenceKey];
}
-- (BOOL)modernUnprefixedWebAudioEnabled
-{
- return [self _boolValueForKey:WebKitModernUnprefixedWebAudioEnabledPreferenceKey];
-}
-
-- (void)setModernUnprefixedWebAudioEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitModernUnprefixedWebAudioEnabledPreferenceKey];
-}
-
-- (BOOL)audioWorkletEnabled
-{
- return [self _boolValueForKey:WebKitAudioWorkletEnabledPreferenceKey];
-}
-
-- (void)setAudioWorkletEnabled:(BOOL)enabled
-{
- [self _setBoolValue:enabled forKey:WebKitAudioWorkletEnabledPreferenceKey];
-}
-
- (BOOL)requestIdleCallbackEnabled
{
return [self _boolValueForKey:WebKitRequestIdleCallbackEnabledPreferenceKey];
Modified: trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h (276714 => 276715)
--- trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h 2021-04-28 15:44:02 UTC (rev 276715)
@@ -326,8 +326,6 @@
// FIXME: If these are not used anywhere, we should remove them and only use WebFeature mechanism for the preference.
@interface WebPreferences (WebPrivatePreferencesConvertedToWebFeature)
@property (nonatomic) BOOL userGesturePromisePropagationEnabled;
-@property (nonatomic) BOOL modernUnprefixedWebAudioEnabled;
-@property (nonatomic) BOOL audioWorkletEnabled;
@property (nonatomic) BOOL requestIdleCallbackEnabled;
@property (nonatomic) BOOL highlightAPIEnabled;
@property (nonatomic) BOOL asyncClipboardAPIEnabled;
Modified: trunk/Source/WebKitLegacy/win/WebView.cpp (276714 => 276715)
--- trunk/Source/WebKitLegacy/win/WebView.cpp 2021-04-28 15:36:11 UTC (rev 276714)
+++ trunk/Source/WebKitLegacy/win/WebView.cpp 2021-04-28 15:44:02 UTC (rev 276715)
@@ -5536,7 +5536,6 @@
#if ENABLE(WEB_AUDIO)
settings.setWebAudioEnabled(true);
settings.setPrefixedWebAudioEnabled(false);
- settings.setModernUnprefixedWebAudioEnabled(true);
#endif // ENABLE(WEB_AUDIO)
#if ENABLE(WEBGL)
