Title: [276728] trunk/LayoutTests/imported/w3c
- Revision
- 276728
- Author
- [email protected]
- Date
- 2021-04-28 12:26:04 -0700 (Wed, 28 Apr 2021)
Log Message
[css-grid] Accurize expected result to 0.5 pixel for some contentSpaceAround tests in abspos
https://bugs.webkit.org/show_bug.cgi?id=225145
Patch by Ziran Sun <[email protected]> on 2021-04-28
Reviewed by Manuel Rego Casasnovas.
There is a 0.5 pixel difference on expected data width for some contentSpaceAround tests in grid
among platforms. This change is to sync the change in WPT and update expectation files.
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001-expected.txt:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001.html:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001-expected.txt:
* web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001.html:
Modified Paths
Diff
Modified: trunk/LayoutTests/imported/w3c/ChangeLog (276727 => 276728)
--- trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-28 19:00:33 UTC (rev 276727)
+++ trunk/LayoutTests/imported/w3c/ChangeLog 2021-04-28 19:26:04 UTC (rev 276728)
@@ -1,3 +1,18 @@
+2021-04-28 Ziran Sun <[email protected]>
+
+ [css-grid] Accurize expected result to 0.5 pixel for some contentSpaceAround tests in abspos
+ https://bugs.webkit.org/show_bug.cgi?id=225145
+
+ Reviewed by Manuel Rego Casasnovas.
+
+ There is a 0.5 pixel difference on expected data width for some contentSpaceAround tests in grid
+ among platforms. This change is to sync the change in WPT and update expectation files.
+
+ * web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001-expected.txt:
+ * web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001.html:
+ * web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001-expected.txt:
+ * web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001.html:
+
2021-04-28 Manuel Rego Casasnovas <[email protected]>
[selectors] Using a modifier key on an element makes it stop matching :focus-visible
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001-expected.txt (276727 => 276728)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001-expected.txt 2021-04-28 19:00:33 UTC (rev 276727)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001-expected.txt 2021-04-28 19:26:04 UTC (rev 276728)
@@ -43,18 +43,8 @@
PASS .grid 42
PASS .grid 43
PASS .grid 44
-FAIL .grid 45 assert_equals:
-<div class="grid contentSpaceAround">
- <div style="grid-column: 2 / auto; grid-row: 2 / auto;" data-offset-x="288" data-offset-y="145" data-expected-width="112" data-expected-height="55">
- </div>
-</div>
-width expected 112 but got 113
-FAIL .grid 46 assert_equals:
-<div class="grid contentSpaceAround">
- <div class="offsets" style="grid-column: 2 / auto; grid-row: 2 / auto;" data-offset-x="288" data-offset-y="145" data-expected-width="112" data-expected-height="55">
- </div>
-</div>
-width expected 112 but got 113
+PASS .grid 45
+PASS .grid 46
PASS .grid 47
PASS .grid 48
PASS .grid 49
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001.html (276727 => 276728)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001.html 2021-04-28 19:00:33 UTC (rev 276727)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-001.html 2021-04-28 19:26:04 UTC (rev 276728)
@@ -306,13 +306,13 @@
<div class="grid contentSpaceAround">
<div style="grid-column: 2 / auto; grid-row: 2 / auto;"
- data-offset-x="288" data-offset-y="145" data-expected-width="112" data-expected-height="55">
+ data-offset-x="288" data-offset-y="145" data-expected-width="112.5" data-expected-height="55">
</div>
</div>
<div class="grid contentSpaceAround">
<div class="offsets" style="grid-column: 2 / auto; grid-row: 2 / auto;"
- data-offset-x="288" data-offset-y="145" data-expected-width="112" data-expected-height="55">
+ data-offset-x="288" data-offset-y="145" data-expected-width="112.5" data-expected-height="55">
</div>
</div>
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001-expected.txt (276727 => 276728)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001-expected.txt 2021-04-28 19:00:33 UTC (rev 276727)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001-expected.txt 2021-04-28 19:26:04 UTC (rev 276728)
@@ -31,18 +31,8 @@
PASS .grid 30
PASS .grid 31
PASS .grid 32
-FAIL .grid 33 assert_equals:
-<div class="grid directionRTL contentSpaceAround">
- <div style="grid-column: auto / 2; grid-row: auto / 2;" data-offset-x="238" data-offset-y="0" data-expected-width="162" data-expected-height="95">
- </div>
-</div>
-width expected 162 but got 163
-FAIL .grid 34 assert_equals:
-<div class="grid directionRTL contentSpaceAround">
- <div class="offsets" style="grid-column: auto / 2; grid-row: auto / 2;" data-offset-x="238" data-offset-y="0" data-expected-width="162" data-expected-height="95">
- </div>
-</div>
-width expected 162 but got 163
+PASS .grid 33
+PASS .grid 34
PASS .grid 35
PASS .grid 36
PASS .grid 37
Modified: trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001.html (276727 => 276728)
--- trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001.html 2021-04-28 19:00:33 UTC (rev 276727)
+++ trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-grid/abspos/grid-positioned-items-content-alignment-rtl-001.html 2021-04-28 19:26:04 UTC (rev 276728)
@@ -234,13 +234,13 @@
<div class="grid directionRTL contentSpaceAround">
<div style="grid-column: auto / 2; grid-row: auto / 2;"
- data-offset-x="238" data-offset-y="0" data-expected-width="162" data-expected-height="95">
+ data-offset-x="238" data-offset-y="0" data-expected-width="162.5" data-expected-height="95">
</div>
</div>
<div class="grid directionRTL contentSpaceAround">
<div class="offsets" style="grid-column: auto / 2; grid-row: auto / 2;"
- data-offset-x="238" data-offset-y="0" data-expected-width="162" data-expected-height="95">
+ data-offset-x="238" data-offset-y="0" data-expected-width="162.5" data-expected-height="95">
</div>
</div>
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
