Title: [276748] trunk/Source/WebCore
- Revision
- 276748
- Author
- [email protected]
- Date
- 2021-04-28 20:55:51 -0700 (Wed, 28 Apr 2021)
Log Message
Use a WeakHashSet for Document::m_mediaElements
https://bugs.webkit.org/show_bug.cgi?id=225082
Unreviewed. Address the review comments by Chris & Darin.
* dom/Document.cpp:
(WebCore::Document::forEachMediaElement):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276747 => 276748)
--- trunk/Source/WebCore/ChangeLog 2021-04-29 01:53:30 UTC (rev 276747)
+++ trunk/Source/WebCore/ChangeLog 2021-04-29 03:55:51 UTC (rev 276748)
@@ -1,3 +1,13 @@
+2021-04-28 Ryosuke Niwa <[email protected]>
+
+ Use a WeakHashSet for Document::m_mediaElements
+ https://bugs.webkit.org/show_bug.cgi?id=225082
+
+ Unreviewed. Address the review comments by Chris & Darin.
+
+ * dom/Document.cpp:
+ (WebCore::Document::forEachMediaElement):
+
2021-04-28 Chris Dumez <[email protected]>
Crash under WebCore::AudioNodeOutput::pull(WebCore::AudioBus*, unsigned long)
Modified: trunk/Source/WebCore/dom/Document.cpp (276747 => 276748)
--- trunk/Source/WebCore/dom/Document.cpp 2021-04-29 01:53:30 UTC (rev 276747)
+++ trunk/Source/WebCore/dom/Document.cpp 2021-04-29 03:55:51 UTC (rev 276748)
@@ -1872,8 +1872,7 @@
{
ASSERT(!m_mediaElements.hasNullReferences());
m_mediaElements.forEach([&](auto& element) {
- auto protectedElement = makeRef(element);
- function(element);
+ function(makeRef(element));
});
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
