Title: [105919] trunk/Source/WebCore
Revision
105919
Author
[email protected]
Date
2012-01-25 12:57:17 -0800 (Wed, 25 Jan 2012)

Log Message

Page Up and Page Down mappings are backwards on BlackBerry port.
https://bugs.webkit.org/show_bug.cgi?id=77021

Fix Page Up and Page Down mappings as they are reversed.

Patch by Mike Fenton <[email protected]> on 2012-01-25
Reviewed by Antonio Gomes.

* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::keyIdentifierForBlackBerryCharacter):
(WebCore::windowsKeyCodeForBlackBerryCharacter):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (105918 => 105919)


--- trunk/Source/WebCore/ChangeLog	2012-01-25 20:52:41 UTC (rev 105918)
+++ trunk/Source/WebCore/ChangeLog	2012-01-25 20:57:17 UTC (rev 105919)
@@ -1,3 +1,16 @@
+2012-01-25  Mike Fenton  <[email protected]>
+
+        Page Up and Page Down mappings are backwards on BlackBerry port.
+        https://bugs.webkit.org/show_bug.cgi?id=77021
+
+        Fix Page Up and Page Down mappings as they are reversed.
+
+        Reviewed by Antonio Gomes.
+
+        * platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
+        (WebCore::keyIdentifierForBlackBerryCharacter):
+        (WebCore::windowsKeyCodeForBlackBerryCharacter):
+
 2012-01-25  Hajime Morita  <[email protected]>
 
         <content> should create HTMLContentElement object

Modified: trunk/Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp (105918 => 105919)


--- trunk/Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp	2012-01-25 20:52:41 UTC (rev 105918)
+++ trunk/Source/WebCore/platform/blackberry/PlatformKeyboardEventBlackBerry.cpp	2012-01-25 20:57:17 UTC (rev 105919)
@@ -73,10 +73,10 @@
         return "Insert";
     case KEYCODE_PG_UP:
     case KEYCODE_KP_PG_UP:
-        return "PageDown";
+        return "PageUp";
     case KEYCODE_PG_DOWN:
     case KEYCODE_KP_PG_DOWN:
-        return "PageUp";
+        return "PageDown";
     case KEYCODE_END:
     case KEYCODE_KP_END:
         return "End";
@@ -299,10 +299,10 @@
         return VK_INSERT;
     case KEYCODE_PG_UP:
     case KEYCODE_KP_PG_UP:
-        return VK_NEXT;
+        return VK_PRIOR;
     case KEYCODE_PG_DOWN:
     case KEYCODE_KP_PG_DOWN:
-        return VK_PRIOR;
+        return VK_NEXT;
     case KEYCODE_END:
     case KEYCODE_KP_END:
         return VK_END;
_______________________________________________
webkit-changes mailing list
[email protected]
http://lists.webkit.org/mailman/listinfo.cgi/webkit-changes

Reply via email to