Title: [276766] trunk/Tools
- Revision
- 276766
- Author
- [email protected]
- Date
- 2021-04-29 05:28:12 -0700 (Thu, 29 Apr 2021)
Log Message
[webkitpy] Remove deprecated slave-config-json-path parameter in perftestsrunner.py
https://bugs.webkit.org/show_bug.cgi?id=225106
Reviewed by Ryosuke Niwa.
* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._parse_args):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(MainTest.test_parse_deprecated_args): Deleted.
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (276765 => 276766)
--- trunk/Tools/ChangeLog 2021-04-29 11:50:30 UTC (rev 276765)
+++ trunk/Tools/ChangeLog 2021-04-29 12:28:12 UTC (rev 276766)
@@ -1,5 +1,17 @@
2021-04-29 Aakash Jain <[email protected]>
+ [webkitpy] Remove deprecated slave-config-json-path parameter in perftestsrunner.py
+ https://bugs.webkit.org/show_bug.cgi?id=225106
+
+ Reviewed by Ryosuke Niwa.
+
+ * Scripts/webkitpy/performance_tests/perftestsrunner.py:
+ (PerfTestsRunner._parse_args):
+ * Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
+ (MainTest.test_parse_deprecated_args): Deleted.
+
+2021-04-29 Aakash Jain <[email protected]>
+
Remove unused slave parameter from run-jsc-benchmarks script
https://bugs.webkit.org/show_bug.cgi?id=225153
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py (276765 => 276766)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2021-04-29 11:50:30 UTC (rev 276765)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner.py 2021-04-29 12:28:12 UTC (rev 276766)
@@ -111,7 +111,7 @@
help="Path to generate a JSON file at; may contain previous results if it already exists."),
optparse.make_option("--reset-results", action=""
help="Clears the content in the generated JSON file before adding the results."),
- optparse.make_option("--slave-config-json-path", "--worker-config-json-path", action='',
+ optparse.make_option("--worker-config-json-path", action='',
callback=_expand_path, type="str", dest="worker_config_json_path",
help="Only used on bots. Path to a worker configuration file."),
optparse.make_option("--description",
Modified: trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py (276765 => 276766)
--- trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2021-04-29 11:50:30 UTC (rev 276765)
+++ trunk/Tools/Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py 2021-04-29 12:28:12 UTC (rev 276766)
@@ -174,11 +174,6 @@
self.assertEqual(options.test_runner_count, 5)
self.assertEqual(options.no_timeout, True)
- def test_parse_deprecated_args(self):
- # FIXME: remove this test and the corresponding parameter after all instances of this deprecated parameter have been removed
- options, _ = PerfTestsRunner._parse_args(['--slave-config-json-path=a/source1.json'])
- self.assertEqual(options.worker_config_json_path, 'a/source1.json')
-
def test_upload_json(self):
runner, port = self.create_runner()
port.host.filesystem.files['/mock-checkout/some.json'] = 'some content'
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
