Title: [276803] trunk/Source/WebCore
- Revision
- 276803
- Author
- [email protected]
- Date
- 2021-04-29 14:56:07 -0700 (Thu, 29 Apr 2021)
Log Message
REGRESSION (r275431): [iOS] fast/events/touch/ios/mouse-events-dispatch-with-touch.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=225208
<rdar://problem/77042369>
Reviewed by Devin Rousso.
* page/Quirks.cpp:
(WebCore::Quirks::simulatedMouseEventTypeForTarget const):
Remove the `!needsQuirks()` check added in r275431 to restore the
original test behavior.
Note that the test overrides `MouseEventsSimulationEnabled`, which
forces `Quirks::shouldDispatchSimulatedMouseEvents` to return true
regardless of `!needsQuirks()`. Furthermore, `NeedsSiteSpecificQuirks`
defaults to false in WebCore.
This change is safe, since `shouldDispatchSimulatedMouseEvents` still
checks `!needsQuirks()` when `MouseEventsSimulationEnabled` is false.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276802 => 276803)
--- trunk/Source/WebCore/ChangeLog 2021-04-29 21:07:41 UTC (rev 276802)
+++ trunk/Source/WebCore/ChangeLog 2021-04-29 21:56:07 UTC (rev 276803)
@@ -1,3 +1,25 @@
+2021-04-29 Aditya Keerthi <[email protected]>
+
+ REGRESSION (r275431): [iOS] fast/events/touch/ios/mouse-events-dispatch-with-touch.html is timing out
+ https://bugs.webkit.org/show_bug.cgi?id=225208
+ <rdar://problem/77042369>
+
+ Reviewed by Devin Rousso.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::simulatedMouseEventTypeForTarget const):
+
+ Remove the `!needsQuirks()` check added in r275431 to restore the
+ original test behavior.
+
+ Note that the test overrides `MouseEventsSimulationEnabled`, which
+ forces `Quirks::shouldDispatchSimulatedMouseEvents` to return true
+ regardless of `!needsQuirks()`. Furthermore, `NeedsSiteSpecificQuirks`
+ defaults to false in WebCore.
+
+ This change is safe, since `shouldDispatchSimulatedMouseEvents` still
+ checks `!needsQuirks()` when `MouseEventsSimulationEnabled` is false.
+
2021-04-29 Devin Rousso <[email protected]>
Unreviewed, fix crashloop after r276744
Modified: trunk/Source/WebCore/page/Quirks.cpp (276802 => 276803)
--- trunk/Source/WebCore/page/Quirks.cpp 2021-04-29 21:07:41 UTC (rev 276802)
+++ trunk/Source/WebCore/page/Quirks.cpp 2021-04-29 21:56:07 UTC (rev 276803)
@@ -478,7 +478,7 @@
Optional<Event::IsCancelable> Quirks::simulatedMouseEventTypeForTarget(EventTarget* target) const
{
- if (!needsQuirks() || !shouldDispatchSimulatedMouseEvents(target))
+ if (!shouldDispatchSimulatedMouseEvents(target))
return { };
// On Google Maps, we want to limit simulated mouse events to dragging the little man that allows entering into Street View.
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
