Log Message
Remove some unneeded code. https://bugs.webkit.org/show_bug.cgi?id=225216 Reviewed by Wenson Hsieh.
* UIProcess/ios/WKContentViewInteraction.h: * UIProcess/ios/WKContentViewInteraction.mm: (-[WKContentView setUpAppHighlightMenusIfNeeded]): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276825 => 276826)
--- trunk/Source/WebKit/ChangeLog 2021-04-30 00:22:13 UTC (rev 276825)
+++ trunk/Source/WebKit/ChangeLog 2021-04-30 01:17:59 UTC (rev 276826)
@@ -1,3 +1,14 @@
+2021-04-29 Megan Gardner <[email protected]>
+
+ Remove some unneeded code.
+ https://bugs.webkit.org/show_bug.cgi?id=225216
+
+ Reviewed by Wenson Hsieh.
+
+ * UIProcess/ios/WKContentViewInteraction.h:
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (-[WKContentView setUpAppHighlightMenusIfNeeded]): Deleted.
+
2021-04-29 Peng Liu <[email protected]>
AVAudioSession throws an exception when WebKit tries to set its routeSharingPolicy to "independent"
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h (276825 => 276826)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2021-04-30 00:22:13 UTC (rev 276825)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.h 2021-04-30 01:17:59 UTC (rev 276826)
@@ -448,10 +448,6 @@
BlockPtr<void()> _actionToPerformAfterReceivingEditDragSnapshot;
#endif
-#if ENABLE(APP_HIGHLIGHTS)
- BOOL _hasSetUpAppHighlightMenus;
-#endif
-
#if HAVE(PEPPER_UI_CORE)
RetainPtr<WKFocusedFormControlView> _focusedFormControlView;
#if HAVE(QUICKBOARD_CONTROLLER)
Modified: trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm (276825 => 276826)
--- trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2021-04-30 00:22:13 UTC (rev 276825)
+++ trunk/Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm 2021-04-30 01:17:59 UTC (rev 276826)
@@ -9138,18 +9138,10 @@
}
#endif
-#if ENABLE(APP_HIGHLIGHTS)
-- (void)setUpAppHighlightMenusIfNeeded
-{
- if (_hasSetUpAppHighlightMenus || !_page->preferences().appHighlightsEnabled() || !self.window || !_page->editorState().selectionIsRange)
- return;
- auto addHighlightCurrentGroupItem = adoptNS([[UIMenuItem alloc] initWithTitle:WebCore::contextMenuItemTagAddHighlightToCurrentGroup() action:@selector(createHighlightInCurrentGroupWithRange:)]);
- auto addHighlightNewGroupItem = adoptNS([[UIMenuItem alloc] initWithTitle:WebCore::contextMenuItemTagAddHighlightToNewGroup() action:@selector(createHighlightInNewGroupWithRange:)]);
- [[UIMenuController sharedMenuController] setMenuItems:@[ addHighlightCurrentGroupItem.get(), addHighlightNewGroupItem.get() ]];
- _hasSetUpAppHighlightMenus = YES;
-}
+
+#if ENABLE(APP_HIGHLIGHTS)
- (void)createHighlightInCurrentGroupWithRange:(id)sender
{
_page->createAppHighlightInSelectedRange(WebCore::CreateNewGroupForHighlight::No, WebCore::HighlightRequestOriginatedInApp::No);
_______________________________________________ webkit-changes mailing list [email protected] https://lists.webkit.org/mailman/listinfo/webkit-changes
