Title: [276845] trunk/Source/WebCore
Revision
276845
Author
[email protected]
Date
2021-04-30 11:18:00 -0700 (Fri, 30 Apr 2021)

Log Message

REGRESSION (iOS 14.5): PWA's / Home Screen Apps with Service Workers intermittenly fail to open offline
https://bugs.webkit.org/show_bug.cgi?id=225083
<rdar://problem/77232062>

Reviewed by Alex Christensen.

Manually tested.

* workers/service/server/SWServerWorker.h:
Initialize m_shouldSkipHandleFetch to false by default.
Otherwise, m_shouldSkipHandleFetch might be used uninitialized during a small amount of time.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (276844 => 276845)


--- trunk/Source/WebCore/ChangeLog	2021-04-30 18:09:53 UTC (rev 276844)
+++ trunk/Source/WebCore/ChangeLog	2021-04-30 18:18:00 UTC (rev 276845)
@@ -1,3 +1,17 @@
+2021-04-30  Youenn Fablet  <[email protected]>
+
+        REGRESSION (iOS 14.5): PWA's / Home Screen Apps with Service Workers intermittenly fail to open offline
+        https://bugs.webkit.org/show_bug.cgi?id=225083
+        <rdar://problem/77232062>
+
+        Reviewed by Alex Christensen.
+
+        Manually tested.
+
+        * workers/service/server/SWServerWorker.h:
+        Initialize m_shouldSkipHandleFetch to false by default.
+        Otherwise, m_shouldSkipHandleFetch might be used uninitialized during a small amount of time.
+
 2021-04-30  Chris Dumez  <[email protected]>
 
         Simplify shouldInvalidateNodeListCachesForAttr() template function

Modified: trunk/Source/WebCore/workers/service/server/SWServerWorker.h (276844 => 276845)


--- trunk/Source/WebCore/workers/service/server/SWServerWorker.h	2021-04-30 18:09:53 UTC (rev 276844)
+++ trunk/Source/WebCore/workers/service/server/SWServerWorker.h	2021-04-30 18:18:00 UTC (rev 276845)
@@ -153,7 +153,7 @@
     bool m_isSkipWaitingFlagSet { false };
     Vector<CompletionHandler<void(bool)>> m_whenActivatedHandlers;
     HashMap<URL, ServiceWorkerContextData::ImportedScript> m_scriptResourceMap;
-    bool m_shouldSkipHandleFetch;
+    bool m_shouldSkipHandleFetch { false };
     bool m_hasTimedOutAnyFetchTasks { false };
     Vector<CompletionHandler<void()>> m_terminationCallbacks;
     Timer m_terminationTimer;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to