Title: [276850] trunk/Source/WebKit
Revision
276850
Author
[email protected]
Date
2021-04-30 12:51:37 -0700 (Fri, 30 Apr 2021)

Log Message

Unreviewed, reverting r276838.

Caused
TestWebKitAPI.WebKit.AlternativeServicesDefaultDirectoryCreation
to fail

Reverted changeset:

"[Cocoa] Always extend access to local process HTTP/3 cache
directory"
https://bugs.webkit.org/show_bug.cgi?id=225171
https://commits.webkit.org/r276838

Modified Paths

Diff

Modified: trunk/Source/WebKit/ChangeLog (276849 => 276850)


--- trunk/Source/WebKit/ChangeLog	2021-04-30 19:16:33 UTC (rev 276849)
+++ trunk/Source/WebKit/ChangeLog	2021-04-30 19:51:37 UTC (rev 276850)
@@ -1,3 +1,18 @@
+2021-04-30  Ryan Haddad  <[email protected]>
+
+        Unreviewed, reverting r276838.
+
+        Caused
+        TestWebKitAPI.WebKit.AlternativeServicesDefaultDirectoryCreation
+        to fail
+
+        Reverted changeset:
+
+        "[Cocoa] Always extend access to local process HTTP/3 cache
+        directory"
+        https://bugs.webkit.org/show_bug.cgi?id=225171
+        https://commits.webkit.org/r276838
+
 2021-04-30  Miguel Gomez  <[email protected]>
 
         [GTK][WPE] Properly recover from unresponsive web processes

Modified: trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm (276849 => 276850)


--- trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm	2021-04-30 19:16:33 UTC (rev 276849)
+++ trunk/Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm	2021-04-30 19:51:37 UTC (rev 276850)
@@ -153,10 +153,13 @@
 
 #if HAVE(CFNETWORK_ALTERNATIVE_SERVICE)
     bool http3Enabled = WebsiteDataStore::http3Enabled();
+    String alternativeServiceStorageDirectory;
     SandboxExtension::Handle alternativeServiceStorageDirectoryExtensionHandle;
-    String alternativeServiceStorageDirectory = resolvedAlternativeServicesStorageDirectory();
-    if (!alternativeServiceStorageDirectory.isEmpty())
-        SandboxExtension::createHandleForReadWriteDirectory(alternativeServiceStorageDirectory, alternativeServiceStorageDirectoryExtensionHandle);
+    if (http3Enabled) {
+        alternativeServiceStorageDirectory = resolvedAlternativeServicesStorageDirectory();
+        if (!alternativeServiceStorageDirectory.isEmpty())
+            SandboxExtension::createHandleForReadWriteDirectory(alternativeServiceStorageDirectory, alternativeServiceStorageDirectoryExtensionHandle);
+    }
 #endif
 
     bool shouldIncludeLocalhostInResourceLoadStatistics = isSafari;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to