Title: [276854] trunk/Source/WebKit
- Revision
- 276854
- Author
- [email protected]
- Date
- 2021-04-30 14:49:41 -0700 (Fri, 30 Apr 2021)
Log Message
ASSERTION FAILED: Unhandled message RemoteRemoteCommandListenerProxy_UpdateSupportedCommands
https://bugs.webkit.org/show_bug.cgi?id=225234
Reviewed by Darin Adler.
We need to keep dispatching (and ignoring) messages for `RemoteRemoteCommandListenerProxy`
after the object is destroyed. That could happen because other web processes may still have
active `RemoteRemoteCommandListener` after `GPUConnectionToWebProcess::m_remoteRemoteCommandListener`
is destroyed.
No new tests. Fix an assertion failure in tests.
* GPUProcess/GPUConnectionToWebProcess.cpp:
(WebKit::GPUConnectionToWebProcess::dispatchMessage):
Modified Paths
Diff
Modified: trunk/Source/WebKit/ChangeLog (276853 => 276854)
--- trunk/Source/WebKit/ChangeLog 2021-04-30 21:30:19 UTC (rev 276853)
+++ trunk/Source/WebKit/ChangeLog 2021-04-30 21:49:41 UTC (rev 276854)
@@ -1,3 +1,20 @@
+2021-04-30 Peng Liu <[email protected]>
+
+ ASSERTION FAILED: Unhandled message RemoteRemoteCommandListenerProxy_UpdateSupportedCommands
+ https://bugs.webkit.org/show_bug.cgi?id=225234
+
+ Reviewed by Darin Adler.
+
+ We need to keep dispatching (and ignoring) messages for `RemoteRemoteCommandListenerProxy`
+ after the object is destroyed. That could happen because other web processes may still have
+ active `RemoteRemoteCommandListener` after `GPUConnectionToWebProcess::m_remoteRemoteCommandListener`
+ is destroyed.
+
+ No new tests. Fix an assertion failure in tests.
+
+ * GPUProcess/GPUConnectionToWebProcess.cpp:
+ (WebKit::GPUConnectionToWebProcess::dispatchMessage):
+
2021-04-30 Wenson Hsieh <[email protected]>
[iOS] Add a heuristic to determine whether a synthetic click triggered any meaningful changes
Modified: trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp (276853 => 276854)
--- trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp 2021-04-30 21:30:19 UTC (rev 276853)
+++ trunk/Source/WebKit/GPUProcess/GPUConnectionToWebProcess.cpp 2021-04-30 21:49:41 UTC (rev 276854)
@@ -658,8 +658,9 @@
}
#endif
- if (m_remoteRemoteCommandListener && decoder.messageReceiverName() == Messages::RemoteRemoteCommandListenerProxy::messageReceiverName()) {
- m_remoteRemoteCommandListener->didReceiveMessage(connection, decoder);
+ if (decoder.messageReceiverName() == Messages::RemoteRemoteCommandListenerProxy::messageReceiverName()) {
+ if (m_remoteRemoteCommandListener)
+ m_remoteRemoteCommandListener->didReceiveMessage(connection, decoder);
return true;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
