Title: [276894] trunk/Source/WebCore
- Revision
- 276894
- Author
- [email protected]
- Date
- 2021-05-03 02:24:34 -0700 (Mon, 03 May 2021)
Log Message
getPropertyValue for url path doesn't return the "#" character
https://bugs.webkit.org/show_bug.cgi?id=215409
Patch by Rob Buis <[email protected]> on 2021-05-03
Reviewed by Youenn Fablet.
Address post review comments.
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::svgPropertyValue):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276893 => 276894)
--- trunk/Source/WebCore/ChangeLog 2021-05-03 08:16:13 UTC (rev 276893)
+++ trunk/Source/WebCore/ChangeLog 2021-05-03 09:24:34 UTC (rev 276894)
@@ -1,3 +1,15 @@
+2021-05-03 Rob Buis <[email protected]>
+
+ getPropertyValue for url path doesn't return the "#" character
+ https://bugs.webkit.org/show_bug.cgi?id=215409
+
+ Reviewed by Youenn Fablet.
+
+ Address post review comments.
+
+ * css/SVGCSSComputedStyleDeclaration.cpp:
+ (WebCore::ComputedStyleExtractor::svgPropertyValue):
+
2021-05-03 Youenn Fablet <[email protected]>
REGRESSION (r276633): fast/mediastream/media-stream-track-interrupted.html is consistently timing out
Modified: trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp (276893 => 276894)
--- trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp 2021-05-03 08:16:13 UTC (rev 276893)
+++ trunk/Source/WebCore/css/SVGCSSComputedStyleDeclaration.cpp 2021-05-03 09:24:34 UTC (rev 276894)
@@ -136,15 +136,15 @@
return SVGLengthValue::toCSSPrimitiveValue(svgStyle.kerning());
case CSSPropertyMarkerEnd:
if (!svgStyle.markerEndResource().isEmpty())
- return CSSPrimitiveValue::create(makeString("#", svgStyle.markerEndResource()), CSSUnitType::CSS_URI);
+ return CSSPrimitiveValue::create(makeString('#', svgStyle.markerEndResource()), CSSUnitType::CSS_URI);
return CSSPrimitiveValue::createIdentifier(CSSValueNone);
case CSSPropertyMarkerMid:
if (!svgStyle.markerMidResource().isEmpty())
- return CSSPrimitiveValue::create(makeString("#", svgStyle.markerMidResource()), CSSUnitType::CSS_URI);
+ return CSSPrimitiveValue::create(makeString('#', svgStyle.markerMidResource()), CSSUnitType::CSS_URI);
return CSSPrimitiveValue::createIdentifier(CSSValueNone);
case CSSPropertyMarkerStart:
if (!svgStyle.markerStartResource().isEmpty())
- return CSSPrimitiveValue::create(makeString("#", svgStyle.markerStartResource()), CSSUnitType::CSS_URI);
+ return CSSPrimitiveValue::create(makeString('#', svgStyle.markerStartResource()), CSSUnitType::CSS_URI);
return CSSPrimitiveValue::createIdentifier(CSSValueNone);
case CSSPropertyStroke:
return adjustSVGPaintForCurrentColor(svgStyle.strokePaintType(), svgStyle.strokePaintUri(), svgStyle.strokePaintColor(), style->color());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
