Title: [276907] trunk
- Revision
- 276907
- Author
- [email protected]
- Date
- 2021-05-03 10:28:41 -0700 (Mon, 03 May 2021)
Log Message
[GLIB] REGRESSION(r276879): Several tests are crashing or failing
https://bugs.webkit.org/show_bug.cgi?id=225292
Reviewed by Carlos Alberto Lopez Perez.
* wtf/FileSystem.cpp:
(WTF::FileSystemImpl::fileIsDirectory): Return false if path is empty.
Modified Paths
Diff
Modified: trunk/LayoutTests/platform/glib/TestExpectations (276906 => 276907)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-05-03 17:23:25 UTC (rev 276906)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-05-03 17:28:41 UTC (rev 276907)
@@ -2356,12 +2356,6 @@
# It was a flaky crash until r275516, but it's still a timeout flaky.
webkit.org/b/224112 media/video-as-img-output-pts.html [ Timeout Pass ]
-webkit.org/b/225292 imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-controls.tentative.html [ Crash ]
-webkit.org/b/225292 imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-punctuation.tentative.html [ Crash ]
-webkit.org/b/225292 imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata-utf-8.html [ Crash ]
-webkit.org/b/225292 imported/w3c/web-platform-tests/FileAPI/file/send-file-formdata.html [ Crash ]
-webkit.org/b/225292 imported/w3c/web-platform-tests/fetch/api/response/response-consume.html [ Crash ]
-
webkit.org/b/225292 imported/w3c/web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.html [ Failure ]
webkit.org/b/225292 imported/w3c/web-platform-tests/html/canvas/offscreen/pixel-manipulation/2d.imageData.get.tiny.worker.html [ Failure ]
Modified: trunk/Source/WTF/ChangeLog (276906 => 276907)
--- trunk/Source/WTF/ChangeLog 2021-05-03 17:23:25 UTC (rev 276906)
+++ trunk/Source/WTF/ChangeLog 2021-05-03 17:28:41 UTC (rev 276907)
@@ -1,3 +1,13 @@
+2021-05-03 Diego Pino Garcia <[email protected]>
+
+ [GLIB] REGRESSION(r276879): Several tests are crashing or failing
+ https://bugs.webkit.org/show_bug.cgi?id=225292
+
+ Reviewed by Carlos Alberto Lopez Perez.
+
+ * wtf/FileSystem.cpp:
+ (WTF::FileSystemImpl::fileIsDirectory): Return false if path is empty.
+
2021-05-03 Chris Dumez <[email protected]>
Restore pre-r276879 behavior for FileSystem::deleteFile() and FileSystem::deleteEmptyDirectory()
Modified: trunk/Source/WTF/wtf/FileSystem.cpp (276906 => 276907)
--- trunk/Source/WTF/wtf/FileSystem.cpp 2021-05-03 17:23:25 UTC (rev 276906)
+++ trunk/Source/WTF/wtf/FileSystem.cpp 2021-05-03 17:28:41 UTC (rev 276907)
@@ -549,6 +549,8 @@
bool fileIsDirectory(const String& path, ShouldFollowSymbolicLinks shouldFollowSymbolicLinks)
{
+ if (path.isEmpty())
+ return false;
std::error_code ec;
std::filesystem::file_status fileStatus;
if (shouldFollowSymbolicLinks == ShouldFollowSymbolicLinks::Yes)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
