Title: [276944] trunk/Source/WebCore
- Revision
- 276944
- Author
- [email protected]
- Date
- 2021-05-03 21:04:23 -0700 (Mon, 03 May 2021)
Log Message
Remove the quirk to disable "return to element fullscreen from picture-in-picture" for wowhead.com
https://bugs.webkit.org/show_bug.cgi?id=225322
Reviewed by Sam Weinig.
The quirk can be removed since wowhead.com has fixed the issue on the page.
Manually tested.
* page/Quirks.cpp:
(WebCore::Quirks::blocksReturnToFullscreenFromPictureInPictureQuirk const):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (276943 => 276944)
--- trunk/Source/WebCore/ChangeLog 2021-05-04 04:03:42 UTC (rev 276943)
+++ trunk/Source/WebCore/ChangeLog 2021-05-04 04:04:23 UTC (rev 276944)
@@ -1,5 +1,19 @@
2021-05-03 Peng Liu <[email protected]>
+ Remove the quirk to disable "return to element fullscreen from picture-in-picture" for wowhead.com
+ https://bugs.webkit.org/show_bug.cgi?id=225322
+
+ Reviewed by Sam Weinig.
+
+ The quirk can be removed since wowhead.com has fixed the issue on the page.
+
+ Manually tested.
+
+ * page/Quirks.cpp:
+ (WebCore::Quirks::blocksReturnToFullscreenFromPictureInPictureQuirk const):
+
+2021-05-03 Peng Liu <[email protected]>
+
Small cleanups in MediaPlayerPrivateMediaSourceAVFObjC and MediaPlayerPrivateAVFoundationObjC
https://bugs.webkit.org/show_bug.cgi?id=225330
Modified: trunk/Source/WebCore/page/Quirks.cpp (276943 => 276944)
--- trunk/Source/WebCore/page/Quirks.cpp 2021-05-04 04:03:42 UTC (rev 276943)
+++ trunk/Source/WebCore/page/Quirks.cpp 2021-05-04 04:04:23 UTC (rev 276944)
@@ -1396,16 +1396,16 @@
bool Quirks::blocksReturnToFullscreenFromPictureInPictureQuirk() const
{
#if ENABLE(FULLSCREEN_API) && ENABLE(VIDEO_PRESENTATION_MODE)
- // Some sites (e.g., wowhead.com and vimeo.com) do not set element's styles properly when a video
+ // Some sites (e.g., vimeo.com) do not set element's styles properly when a video
// returns to fullscreen from picture-in-picture. This quirk disables the "return to fullscreen
- // from picture-in-picture" feature for those sites. We should remove the quirk once rdar://problem/73167861
- // and rdar://problem/73167931 have been fixed.
+ // from picture-in-picture" feature for those sites. We should remove the quirk once
+ // rdar://problem/73167931 has been fixed.
if (!needsQuirks())
return false;
if (!m_blocksReturnToFullscreenFromPictureInPictureQuirk) {
auto domain = RegistrableDomain { m_document->topDocument().url() };
- m_blocksReturnToFullscreenFromPictureInPictureQuirk = domain == "vimeo.com"_s || domain == "wowhead.com"_s;
+ m_blocksReturnToFullscreenFromPictureInPictureQuirk = domain == "vimeo.com"_s;
}
return *m_blocksReturnToFullscreenFromPictureInPictureQuirk;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
