Title: [276948] trunk
Revision
276948
Author
[email protected]
Date
2021-05-03 23:33:52 -0700 (Mon, 03 May 2021)

Log Message

[GPUP] Move GPUProcess WebGL to Experimental Feature
https://bugs.webkit.org/show_bug.cgi?id=222836
rdar://75048190

Patch by Kimmo Kinnunen <[email protected]> on 2021-05-03
Reviewed by Brent Fulgham.

Move the setting for WebGL in GPU process
to experimental features but disable it by default,
even on layout tests.

Source/WTF:

* Scripts/Preferences/WebPreferencesExperimental.yaml:
* Scripts/Preferences/WebPreferencesInternal.yaml:

Tools:

* DumpRenderTree/TestOptions.cpp:
(WTR::TestOptions::defaults):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* WebKitTestRunner/TestOptions.cpp:
(WTR::TestOptions::defaults):

Modified Paths

Diff

Modified: trunk/Source/WTF/ChangeLog (276947 => 276948)


--- trunk/Source/WTF/ChangeLog	2021-05-04 05:54:15 UTC (rev 276947)
+++ trunk/Source/WTF/ChangeLog	2021-05-04 06:33:52 UTC (rev 276948)
@@ -1,3 +1,18 @@
+2021-05-03  Kimmo Kinnunen  <[email protected]>
+
+        [GPUP] Move GPUProcess WebGL to Experimental Feature
+        https://bugs.webkit.org/show_bug.cgi?id=222836
+        rdar://75048190
+
+        Reviewed by Brent Fulgham.
+
+        Move the setting for WebGL in GPU process
+        to experimental features but disable it by default,
+        even on layout tests.
+
+        * Scripts/Preferences/WebPreferencesExperimental.yaml:
+        * Scripts/Preferences/WebPreferencesInternal.yaml:
+
 2021-05-03  Lauro Moura  <[email protected]>
 
         REGRESSION(r276879) Add libstdc++fs to wtf libraries when using experimental fs headers

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml (276947 => 276948)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-05-04 05:54:15 UTC (rev 276947)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesExperimental.yaml	2021-05-04 06:33:52 UTC (rev 276948)
@@ -990,6 +990,17 @@
     WebKit:
       default: WebKit::defaultUseGPUProcessForMediaEnabled()
 
+UseGPUProcessForWebGLEnabled:
+  type: bool
+  humanReadableName: "GPU Process: WebGL"
+  humanReadableDescription: "Process all WebGL operations in GPU Process"
+  webcoreBinding: none
+  condition: ENABLE(GPU_PROCESS) && ENABLE(WEBGL) && !(PLATFORM(GTK) || PLATFORM(WPE))
+  exposed: [ WebKit ]
+  defaultValue:
+    WebKit:
+      default: defaultUseGPUProcessForWebGLEnabled()
+
 UserGesturePromisePropagationEnabled:
   type: bool
   humanReadableName: "UserGesture Promise Propagation"

Modified: trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml (276947 => 276948)


--- trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-05-04 05:54:15 UTC (rev 276947)
+++ trunk/Source/WTF/Scripts/Preferences/WebPreferencesInternal.yaml	2021-05-04 06:33:52 UTC (rev 276948)
@@ -749,17 +749,6 @@
     WebKit:
       default: defaultUseGPUProcessForDOMRenderingEnabled()
 
-UseGPUProcessForWebGLEnabled:
-  type: bool
-  humanReadableName: "GPU Process: WebGL"
-  humanReadableDescription: "Enable WebGL in GPU Process"
-  webcoreBinding: none
-  condition: ENABLE(GPU_PROCESS)
-  exposed: [ WebKit ]
-  defaultValue:
-    WebKit:
-      default: defaultUseGPUProcessForWebGLEnabled()
-
 UseSampledPageTopColorForScrollAreaBackgroundColor:
   type: bool
   humanReadableName: "Use sampled page top color for scroll area background color"

Modified: trunk/Tools/ChangeLog (276947 => 276948)


--- trunk/Tools/ChangeLog	2021-05-04 05:54:15 UTC (rev 276947)
+++ trunk/Tools/ChangeLog	2021-05-04 06:33:52 UTC (rev 276948)
@@ -1,3 +1,22 @@
+2021-05-03  Kimmo Kinnunen  <[email protected]>
+
+        [GPUP] Move GPUProcess WebGL to Experimental Feature
+        https://bugs.webkit.org/show_bug.cgi?id=222836
+        rdar://75048190
+
+        Reviewed by Brent Fulgham.
+
+        Move the setting for WebGL in GPU process
+        to experimental features but disable it by default,
+        even on layout tests.
+
+        * DumpRenderTree/TestOptions.cpp:
+        (WTR::TestOptions::defaults):
+        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
+        (parse_args):
+        * WebKitTestRunner/TestOptions.cpp:
+        (WTR::TestOptions::defaults):
+
 2021-05-03  Chris Dumez  <[email protected]>
 
         Restore pre-r276879 behavior for FileSystem::moveFile()

Modified: trunk/Tools/DumpRenderTree/TestOptions.cpp (276947 => 276948)


--- trunk/Tools/DumpRenderTree/TestOptions.cpp	2021-05-04 05:54:15 UTC (rev 276947)
+++ trunk/Tools/DumpRenderTree/TestOptions.cpp	2021-05-04 06:33:52 UTC (rev 276948)
@@ -170,6 +170,9 @@
             { "WebGPUEnabled", false },
             { "XSSAuditorEnabled", false },
 #endif
+#if ENABLE(GPU_PROCESS) && ENABLE(WEBGL)
+            { "UseGPUProcessForWebGLEnabled", false },
+#endif
         };
 #if PLATFORM(WIN)
         features.uint32WebPreferenceFeatures = {

Modified: trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py (276947 => 276948)


--- trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2021-05-04 05:54:15 UTC (rev 276947)
+++ trunk/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py	2021-05-04 06:33:52 UTC (rev 276948)
@@ -375,10 +375,10 @@
         options.internal_feature.append('CaptureVideoInGPUProcessEnabled')
         options.internal_feature.append('UseGPUProcessForCanvasRenderingEnabled')
         options.internal_feature.append('UseGPUProcessForDOMRenderingEnabled')
-        options.internal_feature.append('UseGPUProcessForWebGLEnabled')
         if not options.experimental_feature:
             options.experimental_feature = []
         options.experimental_feature.append('WebRTCPlatformCodecsInGPUProcessEnabled')
+        options.experimental_feature.append('UseGPUProcessForWebGLEnabled')
         if options.result_report_flavor:
             raise RuntimeError('--use-gpu-process implicitly sets the result flavor, this should not be overridden')
         options.result_report_flavor = 'gpuprocess'

Modified: trunk/Tools/WebKitTestRunner/TestOptions.cpp (276947 => 276948)


--- trunk/Tools/WebKitTestRunner/TestOptions.cpp	2021-05-04 05:54:15 UTC (rev 276947)
+++ trunk/Tools/WebKitTestRunner/TestOptions.cpp	2021-05-04 06:33:52 UTC (rev 276948)
@@ -117,6 +117,9 @@
 #if PLATFORM(IOS_FAMILY_SIMULATOR)
             { "VP9DecoderEnabled", false },
 #endif
+#if ENABLE(GPU_PROCESS) && ENABLE(WEBGL)
+            { "UseGPUProcessForWebGLEnabled", false },
+#endif
         };
         features.stringWebPreferenceFeatures = {
             { "CursiveFontFamily", "Apple Chancery" },
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to