Title: [277018] trunk/Tools
- Revision
- 277018
- Author
- [email protected]
- Date
- 2021-05-05 07:48:02 -0700 (Wed, 05 May 2021)
Log Message
REGRESSION (r272414?): [macOS] TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=221742
<rdar://problem/74220428>
Reviewed by Youenn Fablet.
Make sure the video is looping so that it cannot stop playing before the end of the test.
This is a speculative fix since I haven't been able to reproduce the issue.
* TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
(TEST):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (277017 => 277018)
--- trunk/Tools/ChangeLog 2021-05-05 14:11:56 UTC (rev 277017)
+++ trunk/Tools/ChangeLog 2021-05-05 14:48:02 UTC (rev 277018)
@@ -1,3 +1,17 @@
+2021-05-05 Chris Dumez <[email protected]>
+
+ REGRESSION (r272414?): [macOS] TestWebKitAPI.GPUProcess.CrashWhilePlayingVideo is a flaky failure
+ https://bugs.webkit.org/show_bug.cgi?id=221742
+ <rdar://problem/74220428>
+
+ Reviewed by Youenn Fablet.
+
+ Make sure the video is looping so that it cannot stop playing before the end of the test.
+ This is a speculative fix since I haven't been able to reproduce the issue.
+
+ * TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm:
+ (TEST):
+
2021-05-05 Carlos Garcia Campos <[email protected]>
[SOUP] Wrong cookie timestamp in case of long expire time
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm (277017 => 277018)
--- trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm 2021-05-05 14:11:56 UTC (rev 277017)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/GPUProcess.mm 2021-05-05 14:48:02 UTC (rev 277018)
@@ -317,6 +317,13 @@
[webView synchronouslyLoadTestPageNamed:@"large-videos-with-audio"];
__block bool done = false;
+ [webView evaluateJavaScript:@"document.getElementsByTagName('video')[0].loop = true;" completionHandler:^(id result, NSError *error) {
+ EXPECT_TRUE(!error);
+ done = true;
+ }];
+ TestWebKitAPI::Util::run(&done);
+
+ done = false;
[webView evaluateJavaScript:@"document.getElementsByTagName('video')[0].play() && true" completionHandler:^(id result, NSError *error) {
EXPECT_TRUE(!error);
done = true;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
