Title: [277095] trunk/Source/WebCore
Revision
277095
Author
[email protected]
Date
2021-05-06 09:23:58 -0700 (Thu, 06 May 2021)

Log Message

[MSE][GStreamer] Remove webKitMediaSrcFinalize
https://bugs.webkit.org/show_bug.cgi?id=225458

Reviewed by Philippe Normand.

webKitMediaSrcFinalize was no longer necessary after moving to
WEBKIT_DEFINE_TYPE as requested by the reviewers. This patch cleans
that up.

* platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
(webkit_media_src_class_init):
(webKitMediaSrcFinalize): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (277094 => 277095)


--- trunk/Source/WebCore/ChangeLog	2021-05-06 16:22:45 UTC (rev 277094)
+++ trunk/Source/WebCore/ChangeLog	2021-05-06 16:23:58 UTC (rev 277095)
@@ -1,3 +1,18 @@
+2021-05-06  Alicia Boya GarcĂ­a  <[email protected]>
+
+        [MSE][GStreamer] Remove webKitMediaSrcFinalize
+        https://bugs.webkit.org/show_bug.cgi?id=225458
+
+        Reviewed by Philippe Normand.
+
+        webKitMediaSrcFinalize was no longer necessary after moving to
+        WEBKIT_DEFINE_TYPE as requested by the reviewers. This patch cleans
+        that up.
+
+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
+        (webkit_media_src_class_init):
+        (webKitMediaSrcFinalize): Deleted.
+
 2021-05-06  Mark Lam  <[email protected]>
 
         Forbid further execution in jsc shell if execution is terminated.

Modified: trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp (277094 => 277095)


--- trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp	2021-05-06 16:22:45 UTC (rev 277094)
+++ trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp	2021-05-06 16:23:58 UTC (rev 277095)
@@ -91,7 +91,6 @@
 
 static void webKitMediaSrcUriHandlerInit(gpointer, gpointer);
 static void webKitMediaSrcConstructed(GObject*);
-static void webKitMediaSrcFinalize(GObject*);
 static GstStateChangeReturn webKitMediaSrcChangeState(GstElement*, GstStateChange);
 static gboolean webKitMediaSrcActivateMode(GstPad*, GstObject*, GstPadMode, gboolean activate);
 static void webKitMediaSrcLoop(void*);
@@ -244,7 +243,6 @@
     GstElementClass* eklass = GST_ELEMENT_CLASS(klass);
 
     oklass->constructed = webKitMediaSrcConstructed;
-    oklass->finalize = webKitMediaSrcFinalize;
     oklass->get_property = webKitMediaSrcGetProperty;
 
     gst_element_class_add_static_pad_template_with_gtype(eklass, &srcTemplate, webkit_media_src_pad_get_type());
@@ -275,15 +273,6 @@
     GST_OBJECT_FLAG_SET(object, GST_ELEMENT_FLAG_SOURCE);
 }
 
-static void webKitMediaSrcFinalize(GObject* object)
-{
-    ASSERT(isMainThread());
-
-    WebKitMediaSrc* source = WEBKIT_MEDIA_SRC(object);
-    source->priv->~WebKitMediaSrcPrivate();
-    GST_CALL_PARENT(G_OBJECT_CLASS, finalize, (object));
-}
-
 void webKitMediaSrcEmitStreams(WebKitMediaSrc* source, const Vector<RefPtr<MediaSourceTrackGStreamer>>& tracks)
 {
     ASSERT(isMainThread());
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to