Title: [277133] trunk/Source/WTF
- Revision
- 277133
- Author
- fpi...@apple.com
- Date
- 2021-05-06 15:30:16 -0700 (Thu, 06 May 2021)
Log Message
Remove old and unused memory barrier abstractions
https://bugs.webkit.org/show_bug.cgi?id=225487
Reviewed by Mark Lam.
We don't use memoryBarrierBlahBlah anymore.
* wtf/Atomics.h:
(WTF::memoryBarrierAfterLock): Deleted.
(WTF::memoryBarrierBeforeUnlock): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WTF/ChangeLog (277132 => 277133)
--- trunk/Source/WTF/ChangeLog 2021-05-06 21:59:48 UTC (rev 277132)
+++ trunk/Source/WTF/ChangeLog 2021-05-06 22:30:16 UTC (rev 277133)
@@ -1,5 +1,18 @@
2021-05-06 Filip Pizlo <fpi...@apple.com>
+ Remove old and unused memory barrier abstractions
+ https://bugs.webkit.org/show_bug.cgi?id=225487
+
+ Reviewed by Mark Lam.
+
+ We don't use memoryBarrierBlahBlah anymore.
+
+ * wtf/Atomics.h:
+ (WTF::memoryBarrierAfterLock): Deleted.
+ (WTF::memoryBarrierBeforeUnlock): Deleted.
+
+2021-05-06 Filip Pizlo <fpi...@apple.com>
+
Reduce use of dmb ish on ARM64
https://bugs.webkit.org/show_bug.cgi?id=225465
Modified: trunk/Source/WTF/wtf/Atomics.h (277132 => 277133)
--- trunk/Source/WTF/wtf/Atomics.h 2021-05-06 21:59:48 UTC (rev 277132)
+++ trunk/Source/WTF/wtf/Atomics.h 2021-05-06 22:30:16 UTC (rev 277133)
@@ -274,8 +274,6 @@
inline void loadStoreFence() { arm_dmb(); }
inline void storeLoadFence() { arm_dmb(); }
inline void storeStoreFence() { arm_dmb_st(); }
-inline void memoryBarrierAfterLock() { arm_dmb(); }
-inline void memoryBarrierBeforeUnlock() { arm_dmb(); }
inline void crossModifyingCodeFence() { arm_isb(); }
#elif CPU(X86) || CPU(X86_64)
@@ -312,8 +310,6 @@
inline void loadStoreFence() { compilerFence(); }
inline void storeLoadFence() { x86_ortop(); }
inline void storeStoreFence() { compilerFence(); }
-inline void memoryBarrierAfterLock() { compilerFence(); }
-inline void memoryBarrierBeforeUnlock() { compilerFence(); }
inline void crossModifyingCodeFence() { x86_cpuid(); }
#else
@@ -322,8 +318,6 @@
inline void loadStoreFence() { std::atomic_thread_fence(std::memory_order_seq_cst); }
inline void storeLoadFence() { std::atomic_thread_fence(std::memory_order_seq_cst); }
inline void storeStoreFence() { std::atomic_thread_fence(std::memory_order_seq_cst); }
-inline void memoryBarrierAfterLock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
-inline void memoryBarrierBeforeUnlock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
inline void crossModifyingCodeFence() { std::atomic_thread_fence(std::memory_order_seq_cst); } // Probably not strong enough.
#endif
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
