Title: [277148] trunk/Source/WebCore
Revision
277148
Author
[email protected]
Date
2021-05-06 18:12:51 -0700 (Thu, 06 May 2021)

Log Message

ArtworkImageLoader can call callback with null value.
https://bugs.webkit.org/show_bug.cgi?id=225496
rdar://problem/77631799

Reviewed by Eric Carlson.

The ArtworkImageLoader can call the callback with null to indicate an error.

* Modules/mediasession/MediaMetadata.cpp:
(WebCore::MediaMetadata::refreshArtworkImage): Add null check

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (277147 => 277148)


--- trunk/Source/WebCore/ChangeLog	2021-05-07 01:09:14 UTC (rev 277147)
+++ trunk/Source/WebCore/ChangeLog	2021-05-07 01:12:51 UTC (rev 277148)
@@ -1,3 +1,16 @@
+2021-05-06  Jean-Yves Avenard  <[email protected]>
+
+        ArtworkImageLoader can call callback with null value.
+        https://bugs.webkit.org/show_bug.cgi?id=225496
+        rdar://problem/77631799
+
+        Reviewed by Eric Carlson.
+
+        The ArtworkImageLoader can call the callback with null to indicate an error.
+
+        * Modules/mediasession/MediaMetadata.cpp:
+        (WebCore::MediaMetadata::refreshArtworkImage): Add null check
+
 2021-05-06  Yoshiaki Jitsukawa  <[email protected]>
 
         [OpenSSL] Implement CryptoAlgorithmRSA*

Modified: trunk/Source/WebCore/Modules/mediasession/MediaMetadata.cpp (277147 => 277148)


--- trunk/Source/WebCore/Modules/mediasession/MediaMetadata.cpp	2021-05-07 01:09:14 UTC (rev 277147)
+++ trunk/Source/WebCore/Modules/mediasession/MediaMetadata.cpp	2021-05-07 01:12:51 UTC (rev 277148)
@@ -180,7 +180,7 @@
     // FIXME: Implement a heuristic to retrieve the "best" image.
     m_artworkImageSrc = mediaImages[0].src;
     m_artworkLoader = makeUnique<ArtworkImageLoader>(*m_session->document(), m_artworkImageSrc, [this](Image* image) {
-        if (!image->data())
+        if (!image || !image->data())
             return;
         setArtworkImage(image);
         metadataUpdated();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to