Title: [277164] trunk/LayoutTests
Revision
277164
Author
[email protected]
Date
2021-05-07 01:46:34 -0700 (Fri, 07 May 2021)

Log Message

[GStreamer] Layout test media/video-playsinline.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=186664

Reviewed by Philippe Normand.

The change to fullscreen takes a while on WebKitGTK and WPE platforms and can't be checked immediately.

* media/video-playsinline.html: Added a setTimeout to the test in order to defer the check to the next main loop iteration.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (277163 => 277164)


--- trunk/LayoutTests/ChangeLog	2021-05-07 08:08:40 UTC (rev 277163)
+++ trunk/LayoutTests/ChangeLog	2021-05-07 08:46:34 UTC (rev 277164)
@@ -1,3 +1,14 @@
+2021-05-07  Enrique Ocaña González  <[email protected]>
+
+        [GStreamer] Layout test media/video-playsinline.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=186664
+
+        Reviewed by Philippe Normand.
+
+        The change to fullscreen takes a while on WebKitGTK and WPE platforms and can't be checked immediately.
+
+        * media/video-playsinline.html: Added a setTimeout to the test in order to defer the check to the next main loop iteration.
+
 2021-05-07  Frédéric Wang  <[email protected]>
 
         Crash in InsertTextCommand::positionInsideTextNode

Modified: trunk/LayoutTests/media/video-playsinline.html (277163 => 277164)


--- trunk/LayoutTests/media/video-playsinline.html	2021-05-07 08:08:40 UTC (rev 277163)
+++ trunk/LayoutTests/media/video-playsinline.html	2021-05-07 08:46:34 UTC (rev 277164)
@@ -31,9 +31,12 @@
         });
     })
     waitForEventOnce('playing', async () => {
-        if (expectedDisplayingFullscreen)
+        if (expectedDisplayingFullscreen) {
             await testExpectedEventually('internals.isChangingPresentationMode(video)', false);
 
+            // The GTK/WPE ports take a while to complete the fullscreen change. Wait until the next mainloop iteration.
+            await new Promise(resolve => setTimeout(resolve, 0));
+        }
         testExpected('video.webkitDisplayingFullscreen', expectedDisplayingFullscreen);
         document.body.removeChild(video);
         runNextTest();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to