Title: [277261] trunk
- Revision
- 277261
- Author
- [email protected]
- Date
- 2021-05-10 03:55:30 -0700 (Mon, 10 May 2021)
Log Message
[GStreamer] fast/mediastream/MediaStream-video-element-video-tracks-disabled.html fails
https://bugs.webkit.org/show_bug.cgi?id=225518
Patch by Philippe Normand <[email protected]> on 2021-05-10
Reviewed by Xabier Rodriguez-Calvar.
Source/WebCore:
* platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Fix out-of-bounds memset().
LayoutTests:
* platform/glib/TestExpectations: Unflag a couple more mediastream tests that are passing now.
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (277260 => 277261)
--- trunk/LayoutTests/ChangeLog 2021-05-10 10:02:25 UTC (rev 277260)
+++ trunk/LayoutTests/ChangeLog 2021-05-10 10:55:30 UTC (rev 277261)
@@ -1,3 +1,12 @@
+2021-05-10 Philippe Normand <[email protected]>
+
+ [GStreamer] fast/mediastream/MediaStream-video-element-video-tracks-disabled.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=225518
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/glib/TestExpectations: Unflag a couple more mediastream tests that are passing now.
+
2021-05-10 Rob Buis <[email protected]>
Implement <form>.requestSubmit()
Modified: trunk/LayoutTests/platform/glib/TestExpectations (277260 => 277261)
--- trunk/LayoutTests/platform/glib/TestExpectations 2021-05-10 10:02:25 UTC (rev 277260)
+++ trunk/LayoutTests/platform/glib/TestExpectations 2021-05-10 10:55:30 UTC (rev 277261)
@@ -1110,9 +1110,7 @@
webkit.org/b/79203 fast/mediastream/RTCPeerConnection-inspect-offer-bundlePolicy-bundle-only.html [ Failure Crash ]
webkit.org/b/79203 fast/mediastream/RTCPeerConnection-stats.html [ Timeout Crash ]
webkit.org/b/79203 fast/mediastream/get-display-media-muted.html [ Failure ]
-webkit.org/b/79203 fast/mediastream/mock-media-source-webaudio.html [ Timeout Pass ]
webkit.org/b/79203 webkit.org/b/186678 fast/mediastream/MediaStream-video-element-track-stop.html [ Timeout Failure Crash ]
-webkit.org/b/160996 webkit.org/b/176801 fast/mediastream/MediaStream-video-element-video-tracks-disabled.html [ ImageOnlyFailure Crash ]
fast/mediastream/MediaDevices-addEventListener.html [ DumpJSConsoleLogInStdErr ]
Modified: trunk/Source/WebCore/ChangeLog (277260 => 277261)
--- trunk/Source/WebCore/ChangeLog 2021-05-10 10:02:25 UTC (rev 277260)
+++ trunk/Source/WebCore/ChangeLog 2021-05-10 10:55:30 UTC (rev 277261)
@@ -1,3 +1,12 @@
+2021-05-10 Philippe Normand <[email protected]>
+
+ [GStreamer] fast/mediastream/MediaStream-video-element-video-tracks-disabled.html fails
+ https://bugs.webkit.org/show_bug.cgi?id=225518
+
+ Reviewed by Xabier Rodriguez-Calvar.
+
+ * platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp: Fix out-of-bounds memset().
+
2021-05-10 Rob Buis <[email protected]>
Implement <form>.requestSubmit()
Modified: trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp (277260 => 277261)
--- trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp 2021-05-10 10:02:25 UTC (rev 277260)
+++ trunk/Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp 2021-05-10 10:55:30 UTC (rev 277261)
@@ -267,9 +267,8 @@
{
GstMappedBuffer data(buffer, GST_MAP_WRITE);
auto yOffset = GST_VIDEO_INFO_PLANE_OFFSET(&info, 1);
- auto uOffset = GST_VIDEO_INFO_PLANE_OFFSET(&info, 2);
memset(data.data(), 0, yOffset);
- memset(data.data() + yOffset, 128, uOffset);
+ memset(data.data() + yOffset, 128, data.size() - yOffset);
}
gst_buffer_add_video_meta_full(buffer.get(), GST_VIDEO_FRAME_FLAG_NONE, GST_VIDEO_FORMAT_I420, GST_VIDEO_INFO_WIDTH(&info), GST_VIDEO_INFO_HEIGHT(&info), 3, info.offset, info.stride);
auto blackSample = adoptGRef(gst_sample_new(buffer.get(), caps.get(), nullptr, nullptr));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
