[webkit-changes] [277312] trunk/Source/JavaScriptCore

Mon, 10 May 2021 17:45:38 -0700

Title: [277312] trunk/Source/_javascript_Core
Revision
277312
Author
[email protected]
Date
2021-05-10 17:44:47 -0700 (Mon, 10 May 2021)

Log Message

Removed unused CallRecord::bytecodeIndex field.
https://bugs.webkit.org/show_bug.cgi?id=225627

Reviewed by Yusuke Suzuki.

* jit/JIT.cpp:
(JSC::JIT::privateCompileExceptionHandlers):
* jit/JIT.h:
(JSC::CallRecord::CallRecord):
* jit/JITInlines.h:
(JSC::JIT::emitNakedNearCall):
(JSC::JIT::emitNakedNearTailCall):

Modified Paths

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (277311 => 277312)


--- trunk/Source/_javascript_Core/ChangeLog	2021-05-11 00:41:50 UTC (rev 277311)
+++ trunk/Source/_javascript_Core/ChangeLog	2021-05-11 00:44:47 UTC (rev 277312)
@@ -1,5 +1,20 @@
 2021-05-10  Mark Lam  <[email protected]>
 
+        Removed unused CallRecord::bytecodeIndex field.
+        https://bugs.webkit.org/show_bug.cgi?id=225627
+
+        Reviewed by Yusuke Suzuki.
+
+        * jit/JIT.cpp:
+        (JSC::JIT::privateCompileExceptionHandlers):
+        * jit/JIT.h:
+        (JSC::CallRecord::CallRecord):
+        * jit/JITInlines.h:
+        (JSC::JIT::emitNakedNearCall):
+        (JSC::JIT::emitNakedNearTailCall):
+
+2021-05-10  Mark Lam  <[email protected]>
+
         Add support to collect stats on cumulative LinkBuffer linked sizes based on profiles.
         https://bugs.webkit.org/show_bug.cgi?id=225617

Modified: trunk/Source/_javascript_Core/jit/JIT.cpp (277311 => 277312)


--- trunk/Source/_javascript_Core/jit/JIT.cpp	2021-05-11 00:41:50 UTC (rev 277311)
+++ trunk/Source/_javascript_Core/jit/JIT.cpp	2021-05-11 00:44:47 UTC (rev 277312)
@@ -1027,7 +1027,7 @@
         // operationLookupExceptionHandlerFromCallerFrame is passed one argument, the VM*.
         move(TrustedImmPtr(&vm()), GPRInfo::argumentGPR0);
         prepareCallOperation(vm());
-        m_farCalls.append(FarCallRecord(call(OperationPtrTag), BytecodeIndex(), FunctionPtr<OperationPtrTag>(operationLookupExceptionHandlerFromCallerFrame)));
+        m_farCalls.append(FarCallRecord(call(OperationPtrTag), FunctionPtr<OperationPtrTag>(operationLookupExceptionHandlerFromCallerFrame)));
         jumpToExceptionHandler(vm());
     }
 
@@ -1040,7 +1040,7 @@
         // operationLookupExceptionHandler is passed one argument, the VM*.
         move(TrustedImmPtr(&vm()), GPRInfo::argumentGPR0);
         prepareCallOperation(vm());
-        m_farCalls.append(FarCallRecord(call(OperationPtrTag), BytecodeIndex(), FunctionPtr<OperationPtrTag>(operationLookupExceptionHandler)));
+        m_farCalls.append(FarCallRecord(call(OperationPtrTag), FunctionPtr<OperationPtrTag>(operationLookupExceptionHandler)));
         jumpToExceptionHandler(vm());
     }
 }

Modified: trunk/Source/_javascript_Core/jit/JIT.h (277311 => 277312)


--- trunk/Source/_javascript_Core/jit/JIT.h	2021-05-11 00:41:50 UTC (rev 277311)
+++ trunk/Source/_javascript_Core/jit/JIT.h	2021-05-11 00:44:47 UTC (rev 277312)
@@ -78,7 +78,6 @@
     template<PtrTag tag>
     struct CallRecord {
         MacroAssembler::Call from;
-        BytecodeIndex bytecodeIndex;
         FunctionPtr<tag> callee;
 
         CallRecord()
@@ -85,9 +84,8 @@
         {
         }
 
-        CallRecord(MacroAssembler::Call from, BytecodeIndex bytecodeIndex, FunctionPtr<tag> callee)
+        CallRecord(MacroAssembler::Call from, FunctionPtr<tag> callee)
             : from(from)
-            , bytecodeIndex(bytecodeIndex)
             , callee(callee)
         {
         }
@@ -279,7 +277,7 @@
         Call appendCall(const FunctionPtr<CFunctionPtrTag> function)
         {
             Call functionCall = call(OperationPtrTag);
-            m_farCalls.append(FarCallRecord(functionCall, m_bytecodeIndex, function.retagged<OperationPtrTag>()));
+            m_farCalls.append(FarCallRecord(functionCall, function.retagged<OperationPtrTag>()));
             return functionCall;
         }
 
@@ -287,7 +285,7 @@
         Call appendCallWithSlowPathReturnType(const FunctionPtr<CFunctionPtrTag> function)
         {
             Call functionCall = callWithSlowPathReturnType(OperationPtrTag);
-            m_farCalls.append(FarCallRecord(functionCall, m_bytecodeIndex, function.retagged<OperationPtrTag>()));
+            m_farCalls.append(FarCallRecord(functionCall, function.retagged<OperationPtrTag>()));
             return functionCall;
         }
 #endif

Modified: trunk/Source/_javascript_Core/jit/JITInlines.h (277311 => 277312)


--- trunk/Source/_javascript_Core/jit/JITInlines.h	2021-05-11 00:41:50 UTC (rev 277311)
+++ trunk/Source/_javascript_Core/jit/JITInlines.h	2021-05-11 00:44:47 UTC (rev 277312)
@@ -1,5 +1,5 @@
 /*
- * Copyright (C) 2008-2019 Apple Inc. All rights reserved.
+ * Copyright (C) 2008-2021 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ -93,7 +93,7 @@
 {
     ASSERT(m_bytecodeIndex); // This method should only be called during hot/cold path generation, so that m_bytecodeIndex is set.
     Call nakedCall = nearCall();
-    m_nearCalls.append(NearCallRecord(nakedCall, m_bytecodeIndex, FunctionPtr<JSInternalPtrTag>(target.retagged<JSInternalPtrTag>())));
+    m_nearCalls.append(NearCallRecord(nakedCall, FunctionPtr<JSInternalPtrTag>(target.retagged<JSInternalPtrTag>())));
     return nakedCall;
 }
 
@@ -101,7 +101,7 @@
 {
     ASSERT(m_bytecodeIndex); // This method should only be called during hot/cold path generation, so that m_bytecodeIndex is set.
     Call nakedCall = nearTailCall();
-    m_nearCalls.append(NearCallRecord(nakedCall, m_bytecodeIndex, FunctionPtr<JSInternalPtrTag>(target.retagged<JSInternalPtrTag>())));
+    m_nearCalls.append(NearCallRecord(nakedCall, FunctionPtr<JSInternalPtrTag>(target.retagged<JSInternalPtrTag>())));
     return nakedCall;
 }
 

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to